Page MenuHomeFreeBSD

bhyve vmm statistics tables need to be sized relative to VM_MAXCPU
Needs RevisionPublic

Authored by rgrimes on Fri, Jan 11, 1:53 AM.

Details

Reviewers
jhb
tychon
pmooney_pfmooney.com
araujo
Group Reviewers
bhyve
Summary

You well get message(s) about the in ability to add vmm statistics if you increase VM_MAXCPU as the tables are statically sized at 64, correct that to be (48+VM_MAXCPU) so they scale as you increase this.

This is more of a marker so that the places that depend on VM_MAXCPU can be identified in the process of making it a run time per vm variable.

Test Plan

Load vmm.ko without this change and VM_MAXCPU set ot 24, notice console message, apply this fix and repeat, notice no console message.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rgrimes created this revision.Fri, Jan 11, 1:53 AM
rgrimes updated this revision to Diff 52832.Mon, Jan 14, 5:52 PM

Correct spelling of VM_MAXCPU

araujo requested changes to this revision.Tue, Jan 15, 12:19 AM

It doesn't looks quite right! I need more time to articulate better arguments, but this patch as it is, must not be committed in.

This revision now requires changes to proceed.Tue, Jan 15, 12:19 AM