Differential D18744
Simplify capsicumization of bhyve. Authored by araujo on Jan 4 2019, 12:45 PM. Tags None Referenced Files
Details Use capsicum_helpers(3) that allow us to simplify the code and NOTE: This is the first round of capsicum review, the next round would be to apply cap_fileargs(3).
Diff Detail
Event TimelineComment Actions
But all of the WITHOUT_CAPSICUM #ifdefs have been removed?
Comment Actions Most of it were remove with one single exception that is related with a header vmm_dev.h that I need to check if it is possible to merge with vmm.h. Comment Actions I stopped saying "same" after a while to avoid being too repetitious. I think it would make sense to have one commit that first fixes existing places not yet using helpers to use the helpers by replacing all uses of cap_rights_limit and cap_ioctls_limit with the helper variants. I would keep the == -1 checks though. The syscalls are defined to return -1 on error, not a random -ve value. From cap_rights_limit(2): RETURN VALUES
Upon successful completion, the value 0 is returned; otherwise the value -1
is returned and the global variable errno is set to indicate the error.You could instead perhaps fail for any return value that isn't 0 (e.g use '!= 0'), but using '< 0' is just kind of odd (we fail for half of the undefined values (negative ones), but succeed for the other half (positive values > 0). Using either '== -1' or '!= 0' is more consistent in that all undefined values are treated the same. Personally I would probably use != 0, but the existing code already uses == -1, so I would leave it as is to minimize the diff. I would then probably do a second commit to remove WITHOUT_CAPSICUM and a third commit to add casper for the audio stuff.
Comment Actions Following @jhb suggestion, I will break down these updates in chunks. First of all, I will replace functions that are included on capsicum_helpers(3), Second of all, I need to apologize, I have used devel/coccinelle to make this | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||