Page MenuHomeFreeBSD
Differential D17494

Add missing ZFS sysctls
ClosedPublic
Actions

Authored by allanjude on Oct 10 2018, 5:24 AM.
Tags
None
Referenced Files
F108810264: D17494.diff
Tue, Jan 28, 4:36 AM
Unknown Object (File)
Mon, Jan 13, 8:36 PM
Unknown Object (File)
Fri, Jan 3, 5:36 PM
Unknown Object (File)
Thu, Jan 2, 1:55 PM
Unknown Object (File)
Sep 27 2024, 7:29 PM
Unknown Object (File)
Sep 27 2024, 4:39 PM
Unknown Object (File)
Sep 21 2024, 8:19 AM
Unknown Object (File)
Sep 17 2024, 8:23 PM
View All 31 Files
Subscribers
avg
delphij
imp

Details

Reviewers
mav
mmacy
jpaetzel
avg
Group Reviewers
ZFS
Commits
rS339298: Add missing sysctls for tuning vdev queue depths for new I/O types
Summary

During the merge of rS329502 (zpool remove) and rS337007 (zpool initialize),
freebsd specific code to connect the new tunables was not added.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20107
Build 19602: arc lint + arc unit

Event Timeline

allanjude created this revision.Oct 10 2018, 5:24 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptOct 10 2018, 5:24 AM
Harbormaster completed remote builds in B20107: Diff 48959.Oct 10 2018, 5:24 AM
avg accepted this revision as: avg.Oct 10 2018, 5:30 AM
avg added a subscriber: avg.

LGTM. The change is trivial enough.

This revision is now accepted and ready to land.Oct 10 2018, 5:30 AM
allanjude marked an inline comment as done.Oct 10 2018, 5:34 AM
allanjude added inline comments.
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c
260

@avg While you are here, do you know what this #undef is about? Was it meant to undef ZFS_VDEV_QUEUE_KNOB_MIN and ZFS_VDEV_QUEUE_KNOB_MAX and just got lost in time?

Should it be removed?

avg added inline comments.Oct 10 2018, 6:37 AM
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c
260

It seems that that's how I committed it in rS258632, but mostly likely it was indeed a result of incremental development where I initially had a single macro to define both sysctl-s.

mav accepted this revision.Oct 10 2018, 2:37 PM
Closed by commit rS339298: Add missing sysctls for tuning vdev queue depths for new I/O types (authored by allanjude). · Explain WhyOct 10 2018, 10:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
4 lines

Diff 48959

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c

Loading...