Add SCTP support to dtrace
ClosedPublic
Actions

Authored by tuexen on Aug 22 2018, 6:42 AM.

Details

Reviewers

markj
dteske
gnn
0mp

Group Reviewers

manpages

Commits

rS338213: Add support for send, receive and state-change DTrace providers for

Summary

At BSDCam2018 dteske@ noted that FreeBSD is missing dtrace support for SCTP. This patch adds it based on the Solaris specification in sctp provider for the upcoming Solaris 11.4.

Test Plan

Use the SCTP tests part of this patch.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 22 2018, 6:42 AM

Herald added a reviewer: gnn. · View Herald TranscriptAug 22 2018, 6:42 AM

Herald added a reviewer: manpages. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B19031: Diff 47080.Aug 22 2018, 6:42 AM

I'll admit to being completely unfamiliar with SCTP, but I can't find any problems with this change. Thanks for adding the tests.

share/man/man4/dtrace_sctp.4
206 ↗	(On Diff #47080)	I would be more explicit and note that it implements the same probes as Solaris, but that some probes are FreeBSD-specific. Thus, scripts written for FreeBSD's probes aren't compatible unless the usage is restricted to send, receive and state-change.

The manpage changes look fine from the mdoc(7) syntax perspective.

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2018, 9:23 PM

Closed by commit rS338213: Add support for send, receive and state-change DTrace providers for (authored by tuexen). · Explain Why

This revision was automatically updated to reflect the committed changes.

In D16839#358726, @dteske wrote:

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

Done and fixed the issues reported. Thanks for making me aware of this tool.

share/man/man4/dtrace_sctp.4
206 ↗	(On Diff #47080)	I committed a more specific version stating that the send, receive and state-change provider is compatible and the others are FreeBSD specific.

In D16839#358690, @markj wrote:

I'll admit to being completely unfamiliar with SCTP, but I can't find any problems with this change. Thanks for adding the tests.

Fixed the the version committed.

In D16839#358734, @dteske wrote:

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

I wanted to finish this earlier, but unfortunately it didn't work out. I'm happy to test dwatch extension and tweak the dtrace support if needed.

Thank you so much for your work on this. It is very much appreciated.