Page MenuHomeFreeBSD

Add SCTP support to dtrace
ClosedPublic

Authored by tuexen on Aug 22 2018, 6:42 AM.

Details

Summary

At BSDCam2018 dteske@ noted that FreeBSD is missing dtrace support for SCTP. This patch adds it based on the Solaris specification in sctp provider for the upcoming Solaris 11.4.

Test Plan

Use the SCTP tests part of this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I'll admit to being completely unfamiliar with SCTP, but I can't find any problems with this change. Thanks for adding the tests.

share/man/man4/dtrace_sctp.4
206 ↗(On Diff #47080)

I would be more explicit and note that it implements the same probes as Solaris, but that some probes are FreeBSD-specific. Thus, scripts written for FreeBSD's probes aren't compatible unless the usage is restricted to send, receive and state-change.

0mp added a subscriber: 0mp.

The manpage changes look fine from the mdoc(7) syntax perspective.

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2018, 9:23 PM
This revision was automatically updated to reflect the committed changes.

Please run igor -Dgpxy on the manual changes. OK to ignore any nits it complains about that you didn't introduce yourself.

Done and fixed the issues reported. Thanks for making me aware of this tool.

share/man/man4/dtrace_sctp.4
206 ↗(On Diff #47080)

I committed a more specific version stating that the send, receive and state-change provider is compatible and the others are FreeBSD specific.

I'll admit to being completely unfamiliar with SCTP, but I can't find any problems with this change. Thanks for adding the tests.

Fixed the the version committed.

I would just like to comment for the record that I wish there was more time before the 12.0 release so that I could have created dwatch profiles to simplify tapping into these new hooks. I don't have enough time to develop that before 12.0 is completely frozen.

I wanted to finish this earlier, but unfortunately it didn't work out. I'm happy to test dwatch extension and tweak the dtrace support if needed.

Thank you so much for your work on this. It is very much appreciated.