Combine VM_FREELIST_ISADMA and VM_FREELIST_LOWMEM. They are the same thing.
ClosedPublic
Actions

Authored by imp on Jul 16 2018, 3:57 PM.

Details

Reviewers

manu
markj
alc
marius
br

Summary

Remove it from arm64, riscv and sparc64. It's not needed there.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18072
Build 17812: arc lint + arc unit

Event Timeline

imp created this revision.Jul 16 2018, 3:57 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 16 2018, 3:57 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B18072: Diff 45375.Jul 16 2018, 3:57 PM

imp added reviewers: markj, alc, marius, br.Jul 16 2018, 4:00 PM

markj added inline comments.Jul 16 2018, 4:06 PM

sys/amd64/include/vmparam.h
115	Shouldn't this be 16 << 20?

Seems ok to me with the boundary definition fixed.

This revision is now accepted and ready to land.Jul 16 2018, 4:08 PM

Please go ahead and commit the arm64 and riscv bits, and let me think about the rest.

br accepted this revision.Jul 16 2018, 5:20 PM

imp added inline comments.Jul 16 2018, 5:40 PM

sys/amd64/include/vmparam.h
115	Yes. Here and in i386.

FYI, the few integrated ISA devices found in some sun4u and sun4v machines in fact can do 32-bit DMA so VM_FREELIST_ISADMA can go for sparc64 without a replacement, too.

kbowling added a subscriber: kbowling.Jul 17 2018, 3:48 AM

kbowling added inline comments.

sys/arm64/include/vmparam.h
85	Typo 'oone'

alc accepted this revision.Jul 17 2018, 9:23 PM

alc added inline comments.

sys/amd64/include/vmparam.h
115	Also, a tab instead of a space after the #define here and i386.
sys/i386/include/vmparam.h
100	While you're here, how about adding a comma, specifically, "... ISA DMA, and ..."

Warner, I think that you forgot to reference this review in the commit message, so this review is still open even though this change is committed (in its entirety).

Committed in r336774.