Page MenuHomeFreeBSD

acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic
ClosedPublic

Authored by jason_eggnet.com on Jul 9 2018, 7:47 PM.
Tags
None
Referenced Files
F93158523: D16201.id45084.diff
Sat, Sep 7, 5:57 PM
Unknown Object (File)
Fri, Aug 30, 4:48 PM
Unknown Object (File)
Fri, Aug 30, 4:47 PM
Unknown Object (File)
Fri, Aug 30, 4:47 PM
Unknown Object (File)
Thu, Aug 22, 3:16 PM
Unknown Object (File)
Mon, Aug 19, 2:44 PM
Unknown Object (File)
Sun, Aug 18, 4:48 AM
Unknown Object (File)
Tue, Aug 13, 7:35 PM
Subscribers

Details

Summary

Hopefully simple fix to address panics relating to setting IPV6_TCLASS with setsockopt().

The premise of this fix is that it is ok to call malloc with M_NOWAIT while holding a lock on the in6p.

If it is not ok, then major surgery will be required, as ip6_setpktopt() will have to be fixed (as it also calls malloc with M_NOWAIT) which pulls in the ip6_pcbopts(), ip6_setpktopts(), ip6_setpktopt() call chain. The other call chain does have to be fixed but it can be done in a different review (and with relative ease) if this strategy works out.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable