Page MenuHomeFreeBSD

acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic
ClosedPublic

Authored by jason_eggnet.com on Jul 9 2018, 7:47 PM.
Tags
None
Referenced Files
F151503421: D16201.id.diff
Wed, Apr 8, 9:13 PM
Unknown Object (File)
Wed, Apr 8, 6:07 PM
Unknown Object (File)
Mon, Apr 6, 6:15 AM
Unknown Object (File)
Sat, Apr 4, 4:57 PM
Unknown Object (File)
Tue, Mar 31, 1:44 AM
Unknown Object (File)
Wed, Mar 25, 1:08 AM
Unknown Object (File)
Tue, Mar 24, 4:59 PM
Unknown Object (File)
Sun, Mar 22, 2:36 AM
Subscribers

Details

Summary

Hopefully simple fix to address panics relating to setting IPV6_TCLASS with setsockopt().

The premise of this fix is that it is ok to call malloc with M_NOWAIT while holding a lock on the in6p.

If it is not ok, then major surgery will be required, as ip6_setpktopt() will have to be fixed (as it also calls malloc with M_NOWAIT) which pulls in the ip6_pcbopts(), ip6_setpktopts(), ip6_setpktopt() call chain. The other call chain does have to be fixed but it can be done in a different review (and with relative ease) if this strategy works out.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable