Make Marvell AmadaXP timer driver more generic
ClosedPublic
Actions

Authored by mkm_semihalf.com on Mar 19 2018, 5:35 PM.

Details

Reviewers

mw
loos
manu

Commits

rS331961: Make Marvell AmadaXP timer driver more generic

Summary

Store pointers to SoC specific functions in mv_timer_config structure
and determine proper config at runtime based on compatible string from FDT.
Compatible string for ArmadaXP timers is changed to match Linux FDT.
Armada 38x uses generic Cortex-A9 timer and separate watchdog drivers, so
it does not need to be supported by timer driver.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mkm_semihalf.com created this revision.Mar 19 2018, 5:35 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 19 2018, 5:35 PM

Herald added subscribers: andrew, imp. · View Herald Transcript

Ok for the dts part.

This revision is now accepted and ready to land.Mar 21 2018, 9:47 AM

andrew added inline comments.Mar 21 2018, 10:32 AM

sys/arm/mv/timer.c
305 ↗	(On Diff #40452)	You should split this out to a new function to just handle when the timers have been initialised. The PLATFORM code will perform the software loop in the early boot. Have a look at arm_tmr_do_delay in the generic timer driver for how it's done.