Make Marvell mv_pci.c driver generic
ClosedPublic
Actions

Authored by mkm_semihalf.com on Mar 19 2018, 5:28 PM.

Details

Reviewers

mw
loos
andrew

Commits

rS331953: Make Marvell mv_pci.c driver generic

Summary

PCI ports differ between Marvell SoCs, but have the same compatible in FDT.
Identification is made based on parent compatible during attach.
For ArmadaXP skipping enable procedure is necessary. To achieve it
sc_skip_enable_procedure flag is used.
For Armada38x find root procedure is necessary. For other SoCs root link is
always at slot 0. sc_enable_find_root_slot flag is used to select proper
behaviour.
Marvell armv5 platforms does not support msi.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mkm_semihalf.com created this revision.Mar 19 2018, 5:28 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptMar 19 2018, 5:28 PM

mkm_semihalf.com added a parent revision: D14734: ArmadaXP use INTRNG interrupt controller..Mar 21 2018, 12:22 PM

mkm_semihalf.com added a child revision: D14736: Split get_sar_value function for Marvell ArmadaXP and Armada38X.

andrew added inline comments.Mar 21 2018, 12:57 PM

sys/arm/mv/mv_pci.c
558 ↗	(On Diff #40445)	Why a goto here when there's already an if statement you could add this check to?
1060 ↗	(On Diff #40445)	This comment should be indented