bhyve: actually call bhyve_caph_cache_catpages
ClosedPublic
Actions

Authored by rlibby on Sep 1 2017, 11:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 23, 7:36 AM

	Unknown Object (File)
	Thu, Oct 23, 7:36 AM

	Unknown Object (File)
	Thu, Oct 23, 7:36 AM

	Unknown Object (File)
	Wed, Oct 22, 11:21 PM

	Unknown Object (File)
	Fri, Oct 17, 10:54 PM

	Unknown Object (File)
	Tue, Oct 14, 12:46 AM

	Unknown Object (File)
	Fri, Sep 26, 2:24 AM

	Unknown Object (File)
	Thu, Sep 25, 9:53 PM

Subscribers

Details

Reviewers

grehan

Commits

rS323427: bhyve: actually call bhyve_caph_cache_catpages

Summary

Gcc noticed that bhyve_caph_cache_catpages was defined but unused. It is a stable/11 copy of caph_cache_catpages in head. In head, caph_cache_catpages is called where I have here inserted a call to bhyve_caph_cache_catpages, assuming that was the intention. An alternative fix may be to delete bhyve_caph_cache_catpages entirely.

Direct commit to stable/11. This bug does not apply to head.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Sep 1 2017, 11:44 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2017, 11:44 PM

Harbormaster completed remote builds in B11339: Diff 32603.Sep 1 2017, 11:44 PM

Thanks - this keeps the behviour in sync with head where the routines are hidden in caph helpers, so my opinion is it is best to keep the catpages call.

This revision is now accepted and ready to land.Sep 5 2017, 5:35 AM

Approved

Closed by commit rS323427: bhyve: actually call bhyve_caph_cache_catpages (authored by rlibby). · Explain WhySep 11 2017, 7:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stable/

11/

usr.sbin/

bhyve/

bhyverun.c

2 lines

Diff 32915

View Options

stable/11/usr.sbin/bhyve/bhyverun.c

bhyve: actually call bhyve_caph_cache_catpagesClosedPublicActions