Page MenuHomeFreeBSD

bhyve: actually call bhyve_caph_cache_catpages
ClosedPublic

Authored by rlibby on Sep 1 2017, 11:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 12:46 AM
Unknown Object (File)
Fri, Sep 26, 2:24 AM
Unknown Object (File)
Thu, Sep 25, 9:53 PM
Unknown Object (File)
Aug 28 2025, 11:02 PM
Unknown Object (File)
Jul 31 2025, 7:00 PM
Unknown Object (File)
Jul 27 2025, 6:15 AM
Unknown Object (File)
Jul 27 2025, 6:05 AM
Unknown Object (File)
Jul 26 2025, 7:52 PM

Details

Summary

Gcc noticed that bhyve_caph_cache_catpages was defined but unused. It is a stable/11 copy of caph_cache_catpages in head. In head, caph_cache_catpages is called where I have here inserted a call to bhyve_caph_cache_catpages, assuming that was the intention. An alternative fix may be to delete bhyve_caph_cache_catpages entirely.

Direct commit to stable/11. This bug does not apply to head.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks - this keeps the behviour in sync with head where the routines are hidden in caph helpers, so my opinion is it is best to keep the catpages call.

This revision is now accepted and ready to land.Sep 5 2017, 5:35 AM
This revision was automatically updated to reflect the committed changes.