Always set the receive mask in loader.efi
ClosedPublic
Actions

Authored by andrew on Jul 25 2017, 4:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 12, 12:40 PM

	Unknown Object (File)
	Oct 17 2024, 3:04 AM

	Unknown Object (File)
	Oct 17 2024, 3:04 AM

	Unknown Object (File)
	Oct 17 2024, 3:03 AM

	Unknown Object (File)
	Sep 17 2024, 4:05 PM

	Unknown Object (File)
	Sep 12 2024, 1:59 AM

	Unknown Object (File)
	Sep 8 2024, 7:47 PM

	Unknown Object (File)
	Sep 7 2024, 2:08 PM

View All 50 Files

Subscribers

None

Details

Reviewers

emaste
eric_metricspace.net
tsoome
allanjude
imp
manu

Commits

rS321621: Always set the receive mask in loader.efi. Some UEFI implementations set

Summary

Some UEFI implementations set this to be too restrictive. We need to have
both broadcast and unicast enabled for loader to work. Set them in all
cases to ensure this is true.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10670
Build 11073: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 25 2017, 4:02 PM

LGTM

This revision is now accepted and ready to land.Jul 25 2017, 4:04 PM

Are there some specific examples about systems needing this?

In D11732#243122, @tsoome wrote:

Are there some specific examples about systems needing this?

The dual package ThunderX in the netperf cluster.

If that breaks U-Boot I'll fix U-Boot :)

Closed by commit rS321621: Always set the receive mask in loader.efi. Some UEFI implementations set (authored by andrew). · Explain WhyJul 27 2017, 3:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

boot/

efi/

libefi/

efinet.c

17 lines

Diff 31188

View Options

sys/boot/efi/libefi/efinet.c

Always set the receive mask in loader.efiClosedPublicActions