Always set the receive mask in loader.efi
ClosedPublic
Actions

Authored by andrew on Jul 25 2017, 4:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 14, 8:46 AM

	Unknown Object (File)
	Mon, Apr 14, 3:59 AM

	Unknown Object (File)
	Mon, Apr 14, 12:25 AM

	Unknown Object (File)
	Sun, Apr 13, 11:55 PM

	Unknown Object (File)
	Sat, Mar 22, 9:04 AM

	Unknown Object (File)
	Mar 4 2025, 3:32 PM

	Unknown Object (File)
	Jan 30 2025, 12:14 AM

	Unknown Object (File)
	Jan 27 2025, 11:18 PM

View All 64 Files

Subscribers

None

Details

Reviewers

emaste
eric_metricspace.net
tsoome
allanjude
imp
manu

Commits

rS321621: Always set the receive mask in loader.efi. Some UEFI implementations set

Summary

Some UEFI implementations set this to be too restrictive. We need to have
both broadcast and unicast enabled for loader to work. Set them in all
cases to ensure this is true.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 25 2017, 4:02 PM

LGTM

This revision is now accepted and ready to land.Jul 25 2017, 4:04 PM

Are there some specific examples about systems needing this?

In D11732#243122, @tsoome wrote:

Are there some specific examples about systems needing this?

The dual package ThunderX in the netperf cluster.

If that breaks U-Boot I'll fix U-Boot :)

Closed by commit rS321621: Always set the receive mask in loader.efi. Some UEFI implementations set (authored by andrew). · Explain WhyJul 27 2017, 3:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

libefi/

efinet.c

17 lines

Diff 31258

View Options

head/sys/boot/efi/libefi/efinet.c

Always set the receive mask in loader.efiClosedPublicActions