makefs: Add soft-updates options

[manu]

Summary

Add the ffs option to enable soft-updates.
The option is only processed is ufs2 has been selected.

Test Plan

Creates some image, check mount(8) output.

[manu]

Forgot to bump manpage date.

[kib]

usr.sbin/makefs/ffs/mkfs.c

157 ↗

(On Diff #28462)

If you keep the previous initialization to zero, I argue that this line should use '|='.

[manu]

usr.sbin/makefs/ffs/mkfs.c

157 ↗

(On Diff #28462)

True, I'll update the diff.

[emaste]

usr.sbin/makefs/ffs.h

67 ↗

(On Diff #28462)

I suspect the option (and command line arg etc.) should be "softupdates" - see for example the description in the tunefs man page for -n Turn on/off soft updates

usr.sbin/makefs/ffs/mkfs.c

284 ↗

(On Diff #28462)

isn't this always setting the flag, not just when requested?

[manu]

usr.sbin/makefs/ffs.h

67 ↗

(On Diff #28462)

Agreed, I'll change that

usr.sbin/makefs/ffs/mkfs.c

284 ↗

(On Diff #28462)

That was my quick hack ... will update the diff without it

[manu]

Rename softupdate to softupdates
Remove hack

[emaste]

usr.sbin/makefs/ffs.c

179 ↗

(On Diff #28463)

Note that the option framework has OPT_BOOL see e.g. iso9660 allow-deep-trees. Based on that example I think this could be -soft-updates, which does not take a parameter and just enables SU if specified?

usr.sbin/makefs/ffs.h

67 ↗

(On Diff #28463)

comment ought to be "soft updates' too :-)

[manu]

Correct comment : soft update -> soft updates

[manu]

usr.sbin/makefs/ffs.c

179 ↗

(On Diff #28463)

OPT_BOOL just define a INT32 with values from 0 to 1.
-o softupdates works and is equivalent to -o softupdates=1

[kib]

usr.sbin/makefs/ffs.c

154 ↗

(On Diff #28504)

Unrelated to the review at hands, would be nice to switch ffs_options to use designated initializers.