Page MenuHomeFreeBSD

Update www/chokoq to 1.6.0
ClosedPublic

Authored by tcberner on Mar 28 2017, 6:22 PM.

Details

Summary
  • update it to 1.6.0
  • changes it to being kf5 based
Test Plan

Make sure it runs fine... [not using twitter].

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Would be nice to know how the KWallet integration would work in this case. Any idea if the old wallet is migrated?

www/choqok/files/patch-CMakeLists.txt
7 ↗(On Diff #26736)

Can you send this one upstream?

Would be nice to know how the KWallet integration would work in this case. Any idea if the old wallet is migrated?

To answer my own question, kf5-kwallet has code to migrate KDE4 wallets, but I'm not entirely sure it is triggered.

adridg added inline comments.
www/choqok/files/patch-cmake_modules_FindQtOAuth.cmake
9 ↗(On Diff #26736)

That could probably be upstreamed, too, by introducing some loops over potential pkg-config names, e.g.

set(QOAUTH_NAME_CANDIDATES qoauth-qt5 qoauth)
foreach(_qoauth IN ${QOAUTH_NAME_CANDIDATES})
  pkg_check_modules(PC_QTOAUTH QUIET ${_qoauth})
  # something something, break loop if found, keep the _qoauth around
  # since it's the name we want to use down below, too.
endforeach()
tcberner added a parent revision: D12932: The big KDE-thing.

I think we should also set this behind the move of the kde4 ports and then also have two versions of this one

This revision was not accepted when it landed; it landed in state Changes Planned.Apr 28 2018, 9:56 PM
This revision was automatically updated to reflect the committed changes.