Page MenuHomeFreeBSD

Update kdenlive to 17.04
AbandonedPublic

Authored by tcberner on Jul 8 2017, 11:09 AM.

Details

Reviewers
rakuco
adridg
Summary

This updates kdenlive to the KDE Applications version (Qt5, KF5 based).
This improves co-installability with shotcut, since now both use Qt5
and the same underlying libraries.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10388
Build 10799: arc lint + arc unit

Event Timeline

Looks fine to me. I'd take the opportunity and set LICENSE_FILE and USES=cmake:outsource. However, didn't you say something about it crashing when it's started on IRC?

multimedia/kdenlive/Makefile
4

Instead of

PORTVERSION= 17.04.2
CATEGORIES= multimedia kde
MASTER_SITES=        KDE/stable/applications/${PORTVERSION}/src/

you could use

CATEGORIES=   multimedia kde kde-applications
[...]
# Override KDE Applications version until the ports are up-to-date with upstream.
KDE_APPLICATIONS_VERSION=17.04.2
20

Can you get rid of i18n and only add it via NLS_USE=KDE=i18n ?

multimedia/kdenlive/pkg-plist
290

this does not seem to be sorted

multimedia/kdenlive/Makefile
4

Of course you neeed PORTVERSION=${KDE_APPLICATIONS_VERSION} too

On thursday 17.04.3 will arrive -- could you update the diff against that version?

multimedia/kdenlive/Makefile
60

I think @rakuco mentioned to me recently that this should no longer be needed -- as these targets are only ran when the env-var DESTDIR is not set.

tcberner added a parent revision: D12932: The big KDE-thing.

I think with our new approach this kdenlive should

  1. first be moved to kdenlive-kde4 and
  2. then svn cp back and updated.
This revision now requires changes to proceed.Nov 17 2017, 8:10 PM
tcberner edited reviewers, added: adridg; removed: tcberner.

Committed in rP468528.