Use := to disable branch protection
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
I think I have addressed all the @des points
Address all of des@ points
Remove blank lines at the begining of functions with no local variables.
Thanks for the patch.
Please commit it.
@jhb yes, of course.
In D45293#1033438, @bz wrote:In D45293#1033418, @bz wrote:There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).
I'll have a look tomorrow; in case you see anything but
iwlwifi0: lkpi_sta_scan_to_auth:1310: mo_sta_state(NONE) failed: -5 iwlwifi0: lkpi_iv_newstate: error -1 during state transition 5 (RUN) -> 2 (AUTH)after a firmware crash, please follow up here or on the PR and let me know.
Doh! https://reviews.freebsd.org/D43967 never made it; the description needs updating etc. but the change should go into main as well; it's likely I hit that race. Grrr decade old net80211 problems everyone ignored.
Add a comment explaining why we check mediasize this late.
In D45293#1033443, @imp wrote:Taerdown -> teardown in commit message.
Taerdown -> teardown in commit message.
Updated Test Results with Fix
- The test results in https://reviews.freebsd.org/D45215#1032189 still had some port build errors, so they all have been fixed locally.
- The fix has been rebased to 14.1-BETA3. (2a964a7fc3)
- The tendency of the results are the same as https://reviews.freebsd.org/D45215#1032189.
In D45293#1033418, @bz wrote:There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).
I'll have a look tomorrow; in case you see anything but
iwlwifi0: lkpi_sta_scan_to_auth:1310: mo_sta_state(NONE) failed: -5 iwlwifi0: lkpi_iv_newstate: error -1 during state transition 5 (RUN) -> 2 (AUTH)after a firmware crash, please follow up here or on the PR and let me know.
I'll try to deal with the "pr_debug" marked instances the next days.
In D45293#1033422, @imp wrote:"Tear"
"Tear"
Updated wrong review. Bring back the proper patch.
There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).
Compilation fix.
Compilation fix.
Yesterday
So silly question: what are we trying to solve with these packages in first place?
Historic value to have a copy of the packages saved before they disappear?
Give users a graphical desktop (unlikely with this list)?
Because we always did?
...?