stand/efi: Fix for binutils when targeting arm64
ClosedPublic
Actions

Authored by andrew on Mon, May 20, 11:59 AM.

Details

Reviewers

brooks
imp
emaste
jhb
manu

Group Reviewers

arm64

Commits

rG9f44638ef2c4: stand/efi: Fix for binutils when targeting arm64

Summary

When linking with ld.bfd it complain with the following:

/usr/local/bin/aarch64-unknown-freebsd14.0-ld: start.o: relocation
R_AARCH64_ABS32 against `__data_size' can not be used when making a
shared object

Fix this by marking the __data_size with ABSOLUTE. This returns a
non-relocatable value which appears to be the same behaviour of lld.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Mon, May 20, 11:59 AM

Herald added a reviewer: manu. · View Herald TranscriptMon, May 20, 11:59 AM

Herald added subscribers: dab, bcran. · View Herald Transcript

andrew requested review of this revision.Mon, May 20, 11:59 AM

andrew added a child revision: D45258: stand/kboot: Fix the linker script OUTPUT_FORMAT.

Harbormaster completed remote builds in B57771: Diff 138758.Mon, May 20, 12:01 PM

Even though we relocate this binary, this value is invariant. And less than 32 bits, though that shouldn't matter here

This revision is now accepted and ready to land.Mon, May 20, 12:54 PM

Closed by commit rG9f44638ef2c4: stand/efi: Fix for binutils when targeting arm64 (authored by andrew). · Explain WhyWed, May 22, 8:32 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG9f44638ef2c4: stand/efi: Fix for binutils when targeting arm64.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

arch/

arm64/

arm64.ldscript

2 lines

Diff 138887

View Options

stand/efi/loader/arch/arm64/arm64.ldscript

stand/efi: Fix for binutils when targeting arm64ClosedPublicActions