Page MenuHomeFreeBSD

imp (Warner Losh)
User

Projects

User Details

User Since
Jun 2 2014, 4:20 PM (517 w, 3 d)

Recent Activity

Yesterday

imp committed rGd21c19d4127b: cam/iosched: Document latency buckets correctly. (authored by imp).
cam/iosched: Document latency buckets correctly.
Thu, May 2, 10:02 PM
imp committed rGb12cae88cfb6: nvmecontrol: Allow optional /dev/ for device names (authored by imp).
nvmecontrol: Allow optional /dev/ for device names
Thu, May 2, 9:53 PM
imp added a comment to D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.

I've been thinking about adding PAGE_SIZE_MAX/PAGE_SHIFT_MAX or similar to arm64 to define the largest page size the kernel could support. We could then use that here if it's defined.

Thu, May 2, 2:56 PM

Wed, May 1

imp accepted D44715: nvmecontrol: New commands to support Fabrics hosts.

Thanks for the rework!
I'm just finishing a nvme-cli port :)

Wed, May 1, 10:15 PM
imp added a comment to D40676: ktrace: Record detailed ECAPMODE violations.

After this change, ktrace output is littered with 'CAP system call not allowed: $SYSCALL' on systems w/o capsicum enabled

Are systems without Capsicum still supported? I thought that option was removed in 14.

Wed, May 1, 4:17 PM · capsicum
imp added a comment to D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.

I've run this patch from you and noticed no world build time regressions with a 4k kernel

Wed, May 1, 2:41 PM
imp added a comment to D45032: Boot option to mute console messages after the banner is displayed..

https://cgit.freebsd.org/src/commit/?id=2cb49090114108d594195b9b32c762391340484c

Wed, May 1, 4:08 AM

Tue, Apr 30

imp added inline comments to D44986: Fix new users of MAXPHYS and hide it from the kernel namespace.
Tue, Apr 30, 1:50 AM

Mon, Apr 29

imp requested review of D45012: MINIMAL: Grow minimal to support ata, scsi and nvme.
Mon, Apr 29, 3:16 PM
imp committed rG86fbb05da1ae: ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits (authored by hp_tmm.cx).
ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits
Mon, Apr 29, 2:38 PM
imp committed rGe05b6502f9ca: package: fix dependency generation (authored by lexi_le-fay.org).
package: fix dependency generation
Mon, Apr 29, 2:33 PM
imp committed rG2ef5a8624a15: package: FreeBSD-periodic should depend on FreeBSD-cron (authored by lexi_le-fay.org).
package: FreeBSD-periodic should depend on FreeBSD-cron
Mon, Apr 29, 2:31 PM
imp committed rG702766d09a37: services.5: describe better (authored by concussious.bugzilla_runbox.com).
services.5: describe better
Mon, Apr 29, 2:23 PM
imp committed rGb2b8fa1a64af: Add libxo support to du (authored by Nathan Huff <nhuff@acm.org>).
Add libxo support to du
Mon, Apr 29, 2:23 PM
imp committed rGd289382897e7: rights.4: various corrections on capability rights (authored by CismonX <admin@cismon.net>).
rights.4: various corrections on capability rights
Mon, Apr 29, 4:49 AM
imp committed rG78444b5ade65: glabel: Add support for Linux swap (authored by rbranco_suse.com).
glabel: Add support for Linux swap
Mon, Apr 29, 4:41 AM
imp committed rG0c0a2110f196: package: move authpf into the FreeBSD-pf package (authored by lexi_le-fay.org).
package: move authpf into the FreeBSD-pf package
Mon, Apr 29, 4:35 AM
imp committed rG1b3c07bed63c: package: move OpenBSM auditing into its own package (authored by lexi_le-fay.org).
package: move OpenBSM auditing into its own package
Mon, Apr 29, 4:35 AM
imp committed rG6b1d152d892d: UPDATING: add entry for recent pkgbase changes (authored by lexi_le-fay.org).
UPDATING: add entry for recent pkgbase changes
Mon, Apr 29, 4:35 AM
imp committed rGd94c991f3bcd: setkey: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
setkey: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG70fad8acae73: ipf: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ipf: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG7028e630d611: camcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
camcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGc3c816173d25: ipfw: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ipfw: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGb561d8f59c7d: zonectl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
zonectl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGabab59f662b3: usbconfig: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
usbconfig: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGcbfd42cc07cc: wlandebug: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
wlandebug: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG4c6e656e2e5a: rwhod: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
rwhod: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGf93475cf0fd8: pstat: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
pstat: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG67db7b43d07e: ppp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ppp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGbccbb2fc4bce: ndp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ndp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG83409a9357a4: moused: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
moused: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG338d9c35d55d: kbdcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
kbdcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG8f65dcd6276b: ctld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ctld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG2f8ea2f605ac: ctladm: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ctladm: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG8918cc95e869: btxld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
btxld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rGd1d652c06015: rtadvctl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
rtadvctl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:28 AM
imp committed rG93e96d6c87dc: rtadvd: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
rtadvd: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:27 AM
imp committed rGfdbf7cab91ae: bluetooth: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
bluetooth: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Mon, Apr 29, 4:27 AM
imp committed rG2b8df536a681: axgbe: Various stability improvements (authored by stephan.dewt_yahoo.co.uk).
axgbe: Various stability improvements
Mon, Apr 29, 2:42 AM
imp committed rG6063683eb83a: ada: Another NCQ Trim instability drive (authored by imp).
ada: Another NCQ Trim instability drive
Mon, Apr 29, 2:38 AM

Sun, Apr 28

imp accepted D44754: fattime: make the test code check beyond 32-bit time_t limits.
Sun, Apr 28, 11:14 PM
imp accepted D44753: fattime: make the test code build again.
Sun, Apr 28, 8:48 PM
imp added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.
In D33233#1025445, @imp wrote:

There's almost no difference between sync; shutdown and just shutdow other than more typing. The latter does a sync first thing anyway (in the system call) so you may start the io a smidgen earlier with the former... but sync doesn't guarantee the io will be done before shutdown starts... so even doing them on sepatate lines might only gain you the time it takes you to type shutdown at the expense of typing 5 extra characters.

The main difference is that you control the time you leave to the system to actually write to disk. Typing sync and then shutdown almost immediately indeed doesn't make much sense. Waiting for some seconds or much more does, if you know statistically that all writes will have finished by that chosen time.

Sun, Apr 28, 6:26 PM
imp accepted D44986: Fix new users of MAXPHYS and hide it from the kernel namespace.
Sun, Apr 28, 6:04 PM

Sat, Apr 27

imp added a comment to D44979: in6.h: expose s6_addr* definitions to user level.

Yes. I agree. It will be defined for both kernel and loader builds.

Sat, Apr 27, 7:20 PM
imp committed rG8c81694af438: linux: ignore setsockopt(IPV6_RECVERR) (authored by lexi_le-fay.org).
linux: ignore setsockopt(IPV6_RECVERR)
Sat, Apr 27, 1:04 PM
imp added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

There's almost no difference between sync; shutdown and just shutdow other than more typing. The latter does a sync first thing anyway (in the system call) so you may start the io a smidgen earlier with the former... but sync doesn't guarantee the io will be done before shutdown starts... so even doing them on sepatate lines might only gain you the time it takes you to type shutdown at the expense of typing 5 extra characters.

Sat, Apr 27, 3:12 AM
imp added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

Since reboot and shutdown system calls were added just after v7, the sync 3 times dance is a placebo. It was marginally useful on v7 before powering off. It's existed in lore as being necessary when it hasn't been. And since all it does is schedule IO you can't use it to know data is on the disk.

Sat, Apr 27, 2:17 AM

Fri, Apr 26

imp added inline comments to D44979: in6.h: expose s6_addr* definitions to user level.
Fri, Apr 26, 11:04 PM
imp committed rGf0e59ecff85d: CTL: READ(6) should be allowed on CD devices (authored by hp_tmm.cx).
CTL: READ(6) should be allowed on CD devices
Fri, Apr 26, 3:14 AM

Thu, Apr 25

imp committed rGce3b53ffcc3e: nvmecontrol: Flesh out nvmecontrol format information (authored by imp).
nvmecontrol: Flesh out nvmecontrol format information
Thu, Apr 25, 11:48 PM
imp closed D44958: nvmecontrol: Flesh out nvmecontrol format information.
Thu, Apr 25, 11:48 PM
imp updated the diff for D44958: nvmecontrol: Flesh out nvmecontrol format information.

update per Chuck's idea of making it clear it's an index. Hopefully this makes
it clearer. Thanks Chuck!

Thu, Apr 25, 11:16 PM
imp added reviewers for D44958: nvmecontrol: Flesh out nvmecontrol format information: chuck, chs, mav, manpages.
Thu, Apr 25, 5:25 PM
imp requested review of D44958: nvmecontrol: Flesh out nvmecontrol format information.
Thu, Apr 25, 5:24 PM
imp added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

So I'm not saying we need it now, but we likely need to know if we can... get some sleep

Thu, Apr 25, 4:05 AM
imp added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

I don't suppose that yhese could be generated automatically? It's a huge table to maintain by hand...

Thu, Apr 25, 3:15 AM
imp added a comment to D44935: Unmuting console boot messages for some scenarios.

Any reason to not always set cn_unmute = 0 unconditionally?

Thu, Apr 25, 3:12 AM

Wed, Apr 24

imp committed rG9857f824ec77: arm_kernel_bothdr.awk: Update to latest ota (authored by imp).
arm_kernel_bothdr.awk: Update to latest ota
Wed, Apr 24, 11:59 PM
imp committed rGc7a5881d7a6a: Add support for Intel Atom S1200 UART (authored by henrichhartzer_tuta.io).
Add support for Intel Atom S1200 UART
Wed, Apr 24, 11:59 PM
imp accepted D44931: vfs_lookup.c: only call ktrcapfail() if KTRACE is enabled.
Wed, Apr 24, 7:18 PM
imp accepted D44930: syscalls.master: correct return type of {read,write}v.
Wed, Apr 24, 7:12 PM
imp added a comment to D43463: grdc: add countdown timer mode.

Can we merge this?

Wed, Apr 24, 4:23 AM
imp added a reverting change for rGcf04a7775a4e: swapon: Do not overwrite Linux swap header: rGfeabaf8d5389: Revert "swapon: Do not overwrite Linux swap header".
Wed, Apr 24, 3:19 AM
imp added a reverting change for rG91bdebc958bb: bsdinstall/distfetch.c: check environment variables before downloading and…: rG560931508c7d: Revert "bsdinstall/distfetch.c: check environment variables before downloading….
Wed, Apr 24, 3:19 AM
imp committed rG560931508c7d: Revert "bsdinstall/distfetch.c: check environment variables before downloading… (authored by imp).
Revert "bsdinstall/distfetch.c: check environment variables before downloading…
Wed, Apr 24, 3:19 AM
imp committed rGfeabaf8d5389: Revert "swapon: Do not overwrite Linux swap header" (authored by imp).
Revert "swapon: Do not overwrite Linux swap header"
Wed, Apr 24, 3:19 AM

Tue, Apr 23

imp committed rG91bdebc958bb: bsdinstall/distfetch.c: check environment variables before downloading and… (authored by rilysh <nightquick@proton.me>).
bsdinstall/distfetch.c: check environment variables before downloading and…
Tue, Apr 23, 10:43 PM
imp committed rGcf04a7775a4e: swapon: Do not overwrite Linux swap header (authored by rbranco_suse.com).
swapon: Do not overwrite Linux swap header
Tue, Apr 23, 9:50 PM
imp committed rG4f223e0da7b4: release: Change vmimage EFI GPT label (authored by jlduran_gmail.com).
release: Change vmimage EFI GPT label
Tue, Apr 23, 9:44 PM
imp committed rG14e3f2d8d3eb: nanobsd: Set a GPT label for EFI and cfg partitions (authored by jlduran_gmail.com).
nanobsd: Set a GPT label for EFI and cfg partitions
Tue, Apr 23, 9:44 PM
imp committed rG8a8daeafaf70: sys/*/conf: do not use "../../conf/" when including std.* (authored by lexi_le-fay.org).
sys/*/conf: do not use "../../conf/" when including std.*
Tue, Apr 23, 9:44 PM
imp committed rG4f8f9d708e6a: sys: add conf/std.debug, generic debugging options (authored by lexi_le-fay.org).
sys: add conf/std.debug, generic debugging options
Tue, Apr 23, 9:44 PM
imp committed rG93c5ba5a83d6: sys/netpfil/pf: fix non-INET module build (authored by lexi_le-fay.org).
sys/netpfil/pf: fix non-INET module build
Tue, Apr 23, 9:44 PM
imp committed rG65767e6126a7: sys/net/if_bridge: support non-INET kernels (authored by lexi_le-fay.org).
sys/net/if_bridge: support non-INET kernels
Tue, Apr 23, 9:44 PM
imp committed rGd31b677356d7: ahc(4)/ahd(4): target mode: cancel outstanding AIOs and INOTs (authored by hp_tmm.cx).
ahc(4)/ahd(4): target mode: cancel outstanding AIOs and INOTs
Tue, Apr 23, 9:03 PM
imp committed rG65971073d935: ahc(4) clean up old Linux defines (authored by hp_tmm.cx).
ahc(4) clean up old Linux defines
Tue, Apr 23, 9:03 PM
imp committed rGea6f2d7797c4: checkstyle9.pl: Warn if there's no SOB line (authored by imp).
checkstyle9.pl: Warn if there's no SOB line
Tue, Apr 23, 8:04 PM
imp committed rGe75a1bbc233b: pow,powf(3),__ieee754_rem_pio2(f): Avoid negative integer left shift UB (authored by Karl Tomlinson <karlt+@karlt.net>).
pow,powf(3),__ieee754_rem_pio2(f): Avoid negative integer left shift UB
Tue, Apr 23, 8:04 PM
imp accepted D44916: Stop using strerror() in printf*() guts.

I'd thought we didn't need to propogate the locale, since both strerror and strerror_r use the same locale()... but I'd forgotten printf can have a different one, so I proposed something different in the bug.
We could share buf and errormsg, but maybe it's not worth the hassle.

Tue, Apr 23, 5:32 PM
imp accepted D44911: checkstyle9: Allow a space between "*" and __restrict.
Tue, Apr 23, 1:14 PM
imp committed rG74adb39cf2a5: zfsbootcfg(8), zpool_influxdb(8): move to the zfs package (authored by lexi_le-fay.org).
zfsbootcfg(8), zpool_influxdb(8): move to the zfs package
Tue, Apr 23, 5:04 AM
imp committed rGbac2eea13ae3: swab.c(libc): use a simplified version of byte swapping (authored by rilysh <nightquick@proton.me>).
swab.c(libc): use a simplified version of byte swapping
Tue, Apr 23, 5:04 AM
imp committed rGf578d0199761: ifconfig tunnelfib is implemented in wg(4) (authored by gshapiro).
ifconfig tunnelfib is implemented in wg(4)
Tue, Apr 23, 4:56 AM
imp committed rG05a95d19cb24: alc(4): disable MSI-X by default on Killer cards (authored by lexi_le-fay.org).
alc(4): disable MSI-X by default on Killer cards
Tue, Apr 23, 4:56 AM
imp committed rGe96d0d746844: umount: Support partitions & slices with -d option (authored by rbranco_suse.com).
umount: Support partitions & slices with -d option
Tue, Apr 23, 4:56 AM
imp committed rGc3dd71ab4c1c: share/examples: move examples into appropriate packages (authored by lexi_le-fay.org).
share/examples: move examples into appropriate packages
Tue, Apr 23, 4:56 AM
imp committed rG8aaa58ada45e: package: add DESC and COMMENT for cron package (authored by lexi_le-fay.org).
package: add DESC and COMMENT for cron package
Tue, Apr 23, 4:56 AM
imp committed rG7209444a80fd: package: move cron into its own package (authored by lexi_le-fay.org).
package: move cron into its own package
Tue, Apr 23, 4:56 AM
imp committed rG6ca1f3de5769: package: move hv_{vss,kvp}_daemon into hyperv-tools (authored by lexi_le-fay.org).
package: move hv_{vss,kvp}_daemon into hyperv-tools
Tue, Apr 23, 4:55 AM
imp committed rGca63710d3668: linux: ignore setsockopt(IPV6_RECVERR) (authored by lexi_le-fay.org).
linux: ignore setsockopt(IPV6_RECVERR)
Tue, Apr 23, 4:55 AM
imp committed rG50ecbc5142e1: libipsec: make const-correct (authored by lexi_le-fay.org).
libipsec: make const-correct
Tue, Apr 23, 4:54 AM

Mon, Apr 22

imp accepted D44907: geli.8: minor proofreading.
Mon, Apr 22, 9:16 PM
imp added inline comments to D39636: config.mk: Add MK_VIMAGE knob.
Mon, Apr 22, 8:53 PM
imp accepted D32307: Prepare the system for _FORTIFY_SOURCE.

this looks good to me now (forget about my other comments... I clicked some something weird maybe?)

Mon, Apr 22, 7:25 PM
imp accepted D44904: geli: add a read-only kern.geom.eli.use_uma_bytes sysctl.
Mon, Apr 22, 6:21 PM
imp added a comment to D32307: Prepare the system for _FORTIFY_SOURCE.

I think a rebase is in order... this diff is picking up a lot of "noise" that have nothing to do with fortify....

Mon, Apr 22, 3:52 PM

Sun, Apr 21

imp added inline comments to D44836: mfc-candidates: move pretty printing into lua.
Sun, Apr 21, 2:54 PM

Sat, Apr 20

imp added inline comments to D44884: Throws exception to block redundant devmatch events.
Sat, Apr 20, 11:47 PM
imp added inline comments to D44884: Throws exception to block redundant devmatch events.
Sat, Apr 20, 8:37 PM