Page MenuHomeFreeBSD
Differential D44911

checkstyle9: Allow a space between "*" and __restrict
ClosedPublic
Actions

Authored by 0mp on Tue, Apr 23, 11:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 11:42 AM
Unknown Object (File)
Fri, Apr 26, 10:33 AM
Unknown Object (File)
Fri, Apr 26, 6:12 AM
Unknown Object (File)
Fri, Apr 26, 4:09 AM
Unknown Object (File)
Fri, Apr 26, 3:24 AM
Unknown Object (File)
Fri, Apr 26, 3:24 AM
Unknown Object (File)
Fri, Apr 26, 3:17 AM
Unknown Object (File)
Thu, Apr 25, 9:22 PM
View All 9 Files
Subscribers
des
imp

Details

Reviewers
des
imp
Commits
rG42255af64a54: checkstyle9: Allow a space between "*" and _*restrict
Summary

Before the change, we would get errors like this:

ERROR: "foo * bar" should be "foo *bar"
#369: FILE: foobar.c:369:
+barbaz(char * __restrict s,

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Tue, Apr 23, 11:03 AM
Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 23, 11:03 AM
0mp requested review of this revision.Tue, Apr 23, 11:03 AM
Harbormaster completed remote builds in B57290: Diff 137537.Tue, Apr 23, 11:03 AM
des requested changes to this revision.Tue, Apr 23, 11:27 AM
des added a subscriber: des.
des added inline comments.
tools/build/checkstyle9.pl
212

a) that's not going to work, the | is in the wrong place
b) you want to match restrict (without underscores) as well

This revision now requires changes to proceed.Tue, Apr 23, 11:27 AM
0mp added inline comments.Tue, Apr 23, 11:34 AM
tools/build/checkstyle9.pl
212

Eh, that was a last minute edit to try and sort it. Thank you for catching that.

0mp updated this revision to Diff 137542.Tue, Apr 23, 11:39 AM
  • Fix "|"
  • Add "restrict"
  • Fix indentation
Harbormaster completed remote builds in B57294: Diff 137542.Tue, Apr 23, 11:39 AM
0mp marked an inline comment as done.Tue, Apr 23, 11:40 AM
des added inline comments.Tue, Apr 23, 11:50 AM
tools/build/checkstyle9.pl
206

You could simply use _*restrict| to match both...

0mp updated this revision to Diff 137544.Tue, Apr 23, 12:38 PM

Use a glob

Harbormaster completed remote builds in B57295: Diff 137544.Tue, Apr 23, 12:38 PM
des accepted this revision.Tue, Apr 23, 12:56 PM
This revision is now accepted and ready to land.Tue, Apr 23, 12:56 PM
imp accepted this revision.Tue, Apr 23, 1:14 PM
des added a comment.Tue, Apr 23, 1:57 PM
In D44911#1023975, @0mp wrote:

Use a glob

Kleene star, not glob, these are regular expressions.

Closed by commit rG42255af64a54: checkstyle9: Allow a space between "*" and _*restrict (authored by 0mp). · Explain WhyThu, Apr 25, 9:53 AM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rG42255af64a54: checkstyle9: Allow a space between "*" and _*restrict.
0mp added a comment.Thu, Apr 25, 9:53 AM
In D44911#1023994, @des wrote:
In D44911#1023975, @0mp wrote:

Use a glob

Kleene star, not glob, these are regular expressions.

Okey-dokey :D

0mp added a comment.Thu, Apr 25, 9:53 AM

Thank you for the review!

Revision Contents
Changeset List

PathSize
tools/
build/
1 line

Diff 137653

View Options

tools/build/checkstyle9.pl

Loading...