Another useful group would be operator.

Thanks!

Thank you for the review! :))

• Remove unused variable olderrno
• Use size_t for prefixlen

Thank you for the review!

In D44911#1023994, @des wrote:

In D44911#1023975, @0mp wrote:

Use a glob

Kleene star, not glob, these are regular expressions.

Apply recommended wording

See https://reviews.freebsd.org/D44905

Use a glob

• Fix "|"
• Add "restrict"
• Fix indentation

• Reference clock_gettime from SEE ALSO

• Simplify freeing of old_format.

• Move the ts global variable to main()
  • We pass long nsec to printisodate() because printisodate() does not require the seconds part of timespec. However, setthetime does need both seconds and nanoseconds of timespec, so it makes more sense to pass the whole stuct there.

Update usage() and sort variable declarations in strftime_ns().

Address feedback.

I'll upload an updated patch shortly.

The manual page change LGTM.

Just minor comments you can apply to your future submissions. I'll correct those directly before committing.

Thanks, I'll commit it shortly.

In D42961#979425, @debdrup wrote:

I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.