User Details
User Details
- User Since
- May 17 2014, 3:06 AM (520 w, 6 d)
Today
Today
cat: Missed a couple.
des committed rGc6f9df706410: cat: Check for lack of success rather than a specific failure. (authored by des).
cat: Check for lack of success rather than a specific failure.
Add man page for nfslockd.
des requested review of D45149: cat: Check for lack of success rather than a specific failure..
calendar: cleanup obsolete directories
des added a comment to D45148: atf: Guard against multiple evaluation..
Cool, feel free to open an issue there, I don't want to have to wait weeks or months for a fix.
des requested review of D45148: atf: Guard against multiple evaluation..
des updated the diff for D45086: tftpd: silence gcc overflow warnings.
off by one
Yesterday
Yesterday
des added inline comments to D45132: tftpd: Satisfy clang-analyzer..
des committed rG01872b366578: adduser: Fix confusion between `uclass` and `_class`. (authored by des).
adduser: Fix confusion between `uclass` and `_class`.
pw: Rename some enums.
des committed rG3532d9c66ece: pw: Ensure group membership is not duplicated (authored by naman_freebsdfoundation.org).
pw: Ensure group membership is not duplicated
pw: Rename some enums.
des committed rG9f21d0ef9196: adduser: Fix confusion between `uclass` and `_class`. (authored by des).
adduser: Fix confusion between `uclass` and `_class`.
des committed rGe121845426c8: adduser: Fix confusion between `uclass` and `_class`. (authored by des).
adduser: Fix confusion between `uclass` and `_class`.
pw: Rename some enums.
des requested review of D45139: Add man page for nfslockd..
des updated the summary of D45132: tftpd: Satisfy clang-analyzer..
des updated the diff for D45086: tftpd: silence gcc overflow warnings.
fix length / size confusion
des retitled D45132: tftpd: Satisfy clang-analyzer. from tftpd: Type nit. to tftpd: Satisfy clang-analyzer..
des retitled D45086: tftpd: silence gcc overflow warnings from tftpd: silence gcc -Wformat-overflow warnings to tftpd: silence gcc overflow warnings.
Wed, May 8
Wed, May 8
des requested review of D45132: tftpd: Satisfy clang-analyzer..
des requested review of D45131: tftpd: Add missing include..
des requested review of D45130: tftpd: Drop unneeded includes..
des requested review of D45129: tftpd: Add missing `-S` option to synopsis..
des added a comment to D45086: tftpd: silence gcc overflow warnings.
Would you like me to commandeer this?
des added a comment to D45127: bsdinstall: Stop loading cryptodev for ZFS installations.
You might want to clarify the first bullet point in the commit message: the second part of the sentence seems like a non sequitur or a typo if the reader does not realize that zfs depends on crypto, which is different from cryptodev.
Tue, May 7
Tue, May 7
des committed R11:d46112208bda: x11/mate-desktop: Add run-dep on devel/dconf-editor. (authored by des).
x11/mate-desktop: Add run-dep on devel/dconf-editor.
Mon, May 6
Mon, May 6
pw: Test home directory ownership and mode.
des committed rG46c4e86ebf18: adduser: Fix confusion between `uclass` and `_class`. (authored by des).
adduser: Fix confusion between `uclass` and `_class`.
des committed rGc86119328e6b: pw: Don't silently ignore unparsed command line arguments. (authored by des).
pw: Don't silently ignore unparsed command line arguments.
pw: Rename some enums.
des added a comment to D45099: pw: Test home directory ownership and mode..
This is sort of tangential, and it wouldn't have caught the adduser bug, but I noticed that while several existing test cases verify the existence of the home directory after pw -m, none of them verify its ownership or permissions.
des added a comment to D45098: adduser: Fix confusion between `uclass` and `_class`..
Can you please approve it, then?
des requested review of D45099: pw: Test home directory ownership and mode..
des updated the diff for D45098: adduser: Fix confusion between `uclass` and `_class`..
not in a function
des added a comment to D45098: adduser: Fix confusion between `uclass` and `_class`..
des updated the summary of D45096: pw: Rename some enums..
des updated the diff for D45098: adduser: Fix confusion between `uclass` and `_class`..
move _another_user
des requested review of D45098: adduser: Fix confusion between `uclass` and `_class`..
des requested review of D45097: pw: Don't silently ignore unparsed command line arguments..
des requested review of D45096: pw: Rename some enums..
Sat, May 4
Sat, May 4
des requested changes to D45086: tftpd: silence gcc overflow warnings.
Sorry, I just realized that this is still incorrect. If FILE_SUFFIX_SIZE includes space for the terminator then yyyymmdd is too short. The difference between yyyymmdd and newname should be 4, not 5.
Fri, May 3
Fri, May 3
des added inline comments to D45086: tftpd: silence gcc overflow warnings.
des added inline comments to D45086: tftpd: silence gcc overflow warnings.
des requested changes to D45086: tftpd: silence gcc overflow warnings.
libdiff: More type issues.
des requested review of D45080: libdiff: More type issues..
des abandoned D45079: libdiff: Implement diff coloring..
Sorry, this is a little premature.
des requested review of D45079: libdiff: Implement diff coloring..
diff: Sort headers.
libdiff: Fix type issues.
des updated the diff for D45077: libdiff: Fix type issues..
avoid unnecessary casts
des added inline comments to D45077: libdiff: Fix type issues..
des updated the diff for D45078: diff: Sort headers..
setbuffer was not an improvement
des retitled D45078: diff: Sort headers. from diff: Set a large input buffer when not using `mmap()`. to diff: Sort headers..
des requested review of D45078: diff: Sort headers..
des requested review of D45077: libdiff: Fix type issues..
Thu, May 2
Thu, May 2
des committed rG3f59eb314103: libulog: Make sure ut_line, ut_user, ut_host are terminated. (authored by des).
libulog: Make sure ut_line, ut_user, ut_host are terminated.
des committed rG2bdfc2988986: libulog: Make sure ut_line, ut_user, ut_host are terminated. (authored by des).
libulog: Make sure ut_line, ut_user, ut_host are terminated.
tftpd: Use `size_t` where appropriate.
Tue, Apr 30
Tue, Apr 30
tftpd: Untangle a conditional.
des requested review of D45026: tftpd: Untangle a conditional..
Mon, Apr 29
Mon, Apr 29
des committed rG1da8405cdec4: add defaults for adduser.sh (OK? [yes] & additional user [no]) (authored by admin_hackacad.net).
add defaults for adduser.sh (OK? [yes] & additional user [no])
des committed rG72fc3645e079: adduser(8): support creation of ZFS dataset (authored by john.grafton_runbox.com).
adduser(8): support creation of ZFS dataset
adduser: Overhaul.
adduser: Really fix a syntax error
adduser: Really fix a syntax error
adduser: Overhaul.
des committed rG516009ce8d38: adduser(8): support creation of ZFS dataset (authored by john.grafton_runbox.com).
adduser(8): support creation of ZFS dataset
des committed rGc28253ecde33: libulog: Make sure ut_line, ut_user, ut_host are terminated. (authored by des).
libulog: Make sure ut_line, ut_user, ut_host are terminated.
des retitled D45004: libulog: Make sure ut_line, ut_user, ut_host are terminated. from libulog: Make sure ut_line, ut_user are terminated. to libulog: Make sure ut_line, ut_user, ut_host are terminated..
des requested review of D45004: libulog: Make sure ut_line, ut_user, ut_host are terminated..
Sun, Apr 28
Sun, Apr 28
date: Correctly check outcome of mktime().
Sat, Apr 27
Sat, Apr 27
des requested review of D44982: date: Correctly check outcome of mktime()..
Fix MNT_IGNORE for devfs, fdescfs and nullfs
cp: Clarify an obscure comment.