In D45215#1031630, @imp wrote:What does nvmecontrol identify ndaX say here? What's the optimal I/O boundary? And maybe we should just have a knob to disable trying to use it.
nvmecontrol identify nda4 | grep Opt Optimal I/O Boundary: 256 blocks
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Yesterday
Yesterday
What does nvmecontrol identify ndaX say here? What's the optimal I/O boundary? And maybe we should just have a knob to disable trying to use it.
ctladm: fix resource leak
bhyve: avoid resource leak
imp committed rG304a03275a65: sys/modules/dpdk_lpm4: do not build without INET (authored by lexi_le-fay.org).
sys/modules/dpdk_lpm4: do not build without INET
netstat(8): for -W, use IFNAMSIZ
imp committed rGd33b87e8cf91: netstat(1): increase width of Netif column (authored by lexi_le-fay.org).
netstat(1): increase width of Netif column
imp committed rG1687d77197c0: man filesystems: move driver pages to section four (authored by concussious.bugzilla_runbox.com).
man filesystems: move driver pages to section four
imp committed rG1a720cbec513: man filesystems: fix xrefs after move to section 4 (authored by concussious.bugzilla_runbox.com).
man filesystems: fix xrefs after move to section 4
imp committed rGa03e8a40d404: man filesystems: ObsoleteFiles after move to sec 4 (authored by concussious.bugzilla_runbox.com).
man filesystems: ObsoleteFiles after move to sec 4
Wed, May 15
Wed, May 15
Respectfully, this code is non-standards-conforming, since the standard doesn't allow multiple variable sized elements in a structure.
It's all one sentence one line with a couple minor tweaks that are easy to review.
Yes
Then a quick line in yhe commit messafe saying its a fix
I don't know.. has soft updates cooked enough ? :)
Tue, May 14
Tue, May 14
I'd be more inclined to land the other review, but until it does, this isn't bad.
imp committed rGeb690a0576e8: awk: Merge in bsd-feature branch of OTA from 20240422 (31bb33a32f71) (authored by imp).
awk: Merge in bsd-feature branch of OTA from 20240422 (31bb33a32f71)
imp committed rG887b27736b04: ota: Import bsd-feature branch from 20240422 (31bb33a32f71) (authored by imp).
ota: Import bsd-feature branch from 20240422 (31bb33a32f71)
S/lube/line/. Stupid autocowrecked
Other arch? At the very least a lube in the commit about why not relevant there
Yea. I didn't like it either.
I could move the timeouts into qpair. Then there'd be no more computing the values... I'd have to plumb the sysctl too... it would be cleaner. I could also put the soft timeout in there too. Then it wouldn't be so arbitrary.
Mon, May 13
Mon, May 13
nvme: Add comment about where tr->deadline is set
nvme: Slight simplification
imp committed rG9db8ca92b985: nvme: Slight reworking this loop to match FreeBSD style (authored by imp).
nvme: Slight reworking this loop to match FreeBSD style
nvme: Add locking asserts
imp added a comment to D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
A 32bit freebsd cat reading /compat/linux/mumble
imp added inline comments to D45175: SysV IPC: provide in-kernel helpers to obtain ipcs(8)-like information.
Generally i like it. It does seem to mix memory leak / style fixed in with the new functionality.
Sun, May 12
Sun, May 12
imp added a reverting change for rG099a81a4173b: linprocfs: Add support for proc/sysvipc/{msg,sem,shm}: rG71ffda413069: Revert linprocfs commits.
imp added a reverting change for rG02f481a30b82: linprocfs: Fix i386 time type: rG71ffda413069: Revert linprocfs commits.
imp added a reverting change for rGee2e36686e84: linprocfs: Really fix time_t type issue: rG71ffda413069: Revert linprocfs commits.
Revert linprocfs commits
linprocfs: Really fix time_t type issue
linprocfs: Fix i386 time type
linux: Make module standalone-buildable
Sat, May 11
Sat, May 11
imp committed rG099a81a4173b: linprocfs: Add support for proc/sysvipc/{msg,sem,shm} (authored by rbranco_suse.com).
linprocfs: Add support for proc/sysvipc/{msg,sem,shm}
imp committed rG881ae768f2fd: usb: Remove uneeded revision verbosity from quirks list (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
usb: Remove uneeded revision verbosity from quirks list
imp committed rG64e05e90657f: usb: Fix quirks list (authored by Ahmad Khalifa <ahmadkhalifa570@gmail.com>).
usb: Fix quirks list
imp committed rG9bcc1b18c119: /bin/rmdir: Exit with status 2 for invalid arguments (authored by henrichhartzer_tuta.io).
/bin/rmdir: Exit with status 2 for invalid arguments
imp committed rG3d966ae7895b: nvmecontrol: Appease a meaningless signed error warning thing (authored by imp).
nvmecontrol: Appease a meaningless signed error warning thing
nvmecontrol: Implement telemetry-log command.
stand: Spell LUA_COMPILE_SET correctly.
nvme: Add telemetry page definitions
Fri, May 10
Fri, May 10
So I was aware of this and preferred the pull request. It documented the current policy that's been in place for a while.
I appreciate the views expressed here, but I think it is better to try to resolve this by getting a broader consensus than we can get in a phab review.
I kinda think the project went a little far in subscribing to bde's views on this, but I don't think we'd be well served making a big change to this policy (which has a lot of lurking emotion behind it) via only a phab request.
I do think there's some sympathy for documenting / standardizing at least some of these values, but also a recognition that some are overlapping and confusing and were just Eric's first guess at what to do in sendmail for different errors.
intr: Document how to get the interrupt frame
imp committed rG38c35248fe3b: kern/intr: remove support for passing trap frame as argument (authored by ehem_freebsd_m5p.com).
kern/intr: remove support for passing trap frame as argument
imp committed rG467e3e2f2052: CONTRIBUTING.md/style: spring cleaning (authored by concussious.bugzilla_runbox.com).
CONTRIBUTING.md/style: spring cleaning
imp committed rGa7cc56b28fb1: linux: Adjust rlimit SIGPENDING & MSGQUEUE behaviour to match linprocfs (authored by rbranco_suse.com).
linux: Adjust rlimit SIGPENDING & MSGQUEUE behaviour to match linprocfs
imp added a reverting change for rG6ed7d0e3ac9c: grdc: Add copyright: rG88cbbbb6070c: Revert "grdc: Add copyright".
Revert "grdc: Add copyright"
grdc: add countdown timer mode
grdc: Add copyright
imp committed rG06af7bd12a4a: posix: POSIX-1.2008 moved SA_* from XSI to base standard (authored by imp).
posix: POSIX-1.2008 moved SA_* from XSI to base standard
imp committed rGb01988d5e570: mdconfig: Print options when listing devices (authored by rbranco_suse.com).
mdconfig: Print options when listing devices
Explain cron.d
imp committed rG783baf00128f: at cron file is now in /etc/cron.d (authored by Paweł Krawczyk <p+freebsd@krvtz.net>).
at cron file is now in /etc/cron.d
imp committed rG5ccaab1797e5: sysexits: Tidy deprecated header and manual (authored by concussious.bugzilla_runbox.com).
sysexits: Tidy deprecated header and manual
imp committed rG9f91b8aaf5da: Update README.md to add pointer to release page. (authored by Lukas R. Jackson <Lukasjacksoneg@gmail.com>).
Update README.md to add pointer to release page.
ahc(4): Default to memory mapped IO
imp committed rG09025a714708: ipfw: correctly report table manipulation errors (authored by ben_desync.com).
ipfw: correctly report table manipulation errors
imp committed rG12be6f12e87a: Fix memory corruption in C++ demangler (authored by Justine Tunney <jtunney@gmail.com>).
Fix memory corruption in C++ demangler
Thu, May 9
Thu, May 9
imp committed rG8c2f6c3be012: Address module reproducibility issues (authored by dan.mcgregor_usask.ca).
Address module reproducibility issues
imp committed rGcd917a17bc39: arp.8: don't document a syntax that doesn't exist (authored by lexi_le-fay.org).
arp.8: don't document a syntax that doesn't exist
imp committed rGd9817976625f: intr/x86: replace use of vector in interface with intsrc (authored by ehem_freebsd_m5p.com).
intr/x86: replace use of vector in interface with intsrc
imp committed rG98c276811aec: arm: add missing atomic-pointer functions (authored by ehem_freebsd_m5p.com).
arm: add missing atomic-pointer functions
sys: declare bit sets unsigned
imp committed rG9f3a552f9e1a: intrng: switch flag arguments to unsigned (authored by ehem_freebsd_m5p.com).
intrng: switch flag arguments to unsigned
imp committed rGa9e0f316b3da: kern/intr: redeclare intr_setaffinity()'s third arg constant (authored by ehem_freebsd_m5p.com).
kern/intr: redeclare intr_setaffinity()'s third arg constant
imp committed rGcd04887b9569: kern/intr: change ->ie_irq to unsigned (authored by ehem_freebsd_m5p.com).
kern/intr: change ->ie_irq to unsigned
imp committed rGe64318e76ed9: arm/pmu: remove passing trap frame as argument (authored by ehem_freebsd_m5p.com).
arm/pmu: remove passing trap frame as argument
Since these aren't exported or used anywhere, I think they are safe to remove.
Update example from gcc6 to gcc13
Wed, May 8
Wed, May 8
What do you do if neither INET nor INET6 are defined? In a lot of cases, it looks like you fail. Likewise for when you don't have the right address family compiled in.
Tue, May 7
Tue, May 7
makes sense @emaste. Thanks!
The build is good, modulo one quibble.
The rest looks OK, but is really too large for me to review.
ah, mechanically generated code.
Seems reasonable, but it's a bit large to know for sure.
This looks straight forward enough that I'm happy ...