I don't understand enough to review in depth but looks OK. One nit I noticed in a comment.

OK, this is good enough for now.

correct history

In D45243#1033059, @des wrote:

In D45243#1032859, @pjd wrote:

In D45243#1032364, @des wrote:

Have you considered implementing Apple's copyfile API?

I did, but I cannot commit that much time to implement it.

I'm not suggesting implementing the full API; just COPYFILE_DATA and COPYFILE_STAT and a handful of modifiers (COPYFILE_DATA_SPARSE, COPYFILE_EXCL, COPYFILE_MOVE, COPYFILE_NOFOLLOW, COPYFILE_UNLINK) should suffice. I'd offer to help, but I've seen the source code (it's on GitHub under APSL) so I probably shouldn't.

Update commit message as suggested by jrtc27

Oh and MFC after?

Though please change your Fixes to be 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

Can you please add IOMMU to arm64 NOTES?

Mention EXAMPLES section in mixer_get_nmixers().

Update mixer_get_nmixers() entry in mixer.3.

Anyone any comments? Otherwise I'll put that in soon.

Anyone? As otherwise this will go in within 24h.

Anyone? Otherwise this will go in within 24h.

The updates look good to me.

LGTM. "whether an attempt to access the file" is definitely an improvement

So for mostly idle machines, this increases the spacing between ':', ',', and values. Perhaps doing it conditionally is worse because the placement of the values would blink.

be more explicit

In D44945#1033260, @bz wrote:

@jrm given I am not a ports committer how do I proceed? I assume I need an Approved by: line from someone?

@jrm given I am not a ports committer how do I proceed? I assume I need an Approved by: line from someone?

Rework a bit to reduce duplication.

Looks good to me. Thanks.

Included the important Reported by in the commit. Thanks.

Better indeed to return ENXIO early in g_vfs_open() and remove the special case for 0 in vnode_create_vobject(). Thanks.

"Access and friends provide a good first guess if a future open might succeed." Might be good to insert at the start. Or "access, eaccess and faccessat provide..." and change the list at the start of the next sentence to "These system calls".

Must have done something wrong. I'll figure it out eventually. Plan to get arcanist going asap. Generally looks good! Thanks!

Hi Chris,

In D45287#1033199, @rlibby wrote:

In D45287#1033196, @jhibbits wrote:

The only time this makes a difference is if the sizes of bus_addr_t and bus_size_t are different, and I don't have any test hardware where that's the case and I can test TPM. (Only hardware I have where that's the case is ppc Book-E, but that doesn't have a TPM).

Right. Not that I think this is risky, but would you like to do any testing of tpm at all before pushing to main? Otherwise I'll go ahead and push it without testing beyond make.

When committing, please push the core changes alone. Then do the hyper-v part as a separate commit.

The core changes look fine to me. I have no idea about hyper-v part.