Page MenuHomeFreeBSD

zec (Marko Zec)
User

Projects

User Details

User Since
Dec 14 2014, 3:26 PM (539 w, 2 d)

Recent Activity

Feb 27 2025

zec added a comment to D49158: ng_eiface(4) and ng_iface(4) should play better with vnet(9).

I do not like the plan. The picture drawn shows that a netgraph node in one vnet is connected to a node in a different vnet. This is basically a violation of the idea of vnet. Virtualized stacks should communicate with each other via network protocols, not kernel pointers. The only legal exclusion is epair(4).

Feb 27 2025, 7:13 PM · Jails, network
zec added a comment to D49158: ng_eiface(4) and ng_iface(4) should play better with vnet(9).

By design, moving an eiface ifnet from one vnet to another always implied that its netgraph node will remain attached in the parent vnet. This is not an omission or a mistake, but a well established mode of operation on which certain applications heavily depend on, and which this patch proposes to change, for reasons not clearly stated.

Feb 27 2025, 6:14 PM · Jails, network

May 23 2024

zec committed rG782f02004251: fib_dxr: check if cached fib_data matches the new request in dxr_init() (authored by zec).
fib_dxr: check if cached fib_data matches the new request in dxr_init()
May 23 2024, 5:38 AM
zec committed rG0e5e6a9419ea: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
May 23 2024, 5:38 AM
zec committed rGcf879fdb4820: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
May 23 2024, 5:38 AM
zec committed rG47fb63a288cd: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
May 23 2024, 5:38 AM
zec committed rG4df0c59feb66: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
May 23 2024, 5:38 AM
zec committed rG78782f3dd2f2: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
May 23 2024, 5:38 AM
zec committed rG78ae540decdc: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
May 23 2024, 5:38 AM

May 22 2024

zec committed rGb0a1a3138a37: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
May 22 2024, 5:53 PM
zec committed rG913a955bf55d: fib_dxr: code hygiene, prune old code, no functional changes (authored by zec).
fib_dxr: code hygiene, prune old code, no functional changes
May 22 2024, 5:39 PM
zec committed rG56d8fb274847: fib_dxr: do not leak memory if FIB constellation hits structural limit (authored by zec).
fib_dxr: do not leak memory if FIB constellation hits structural limit
May 22 2024, 5:39 PM
zec committed rG9629a4b6865c: fib_dxr: check if cached fib_data matches the new request in dxr_init() (authored by zec).
fib_dxr: check if cached fib_data matches the new request in dxr_init()
May 22 2024, 5:38 PM
zec committed rG1266d894c50c: fib_dxr: code hygiene, prune old code, no functional changes (authored by zec).
fib_dxr: code hygiene, prune old code, no functional changes
May 22 2024, 5:36 PM
zec committed rGada1d9b8edbd: fib_dxr: do not leak memory if FIB constellation hits structural limit (authored by zec).
fib_dxr: do not leak memory if FIB constellation hits structural limit
May 22 2024, 5:36 PM
zec committed rGd6e32525c778: fib_dxr: check if cached fib_data matches the new request in dxr_init() (authored by zec).
fib_dxr: check if cached fib_data matches the new request in dxr_init()
May 22 2024, 5:35 PM

May 17 2024

zec committed rG42b3c16e3051: fib_dxr: code hygiene, prune old code, no functional changes (authored by zec).
fib_dxr: code hygiene, prune old code, no functional changes
May 17 2024, 5:06 PM
zec committed rG19bd24caa4c8: fib_dxr: do not leak memory if FIB constellation hits structural limit (authored by zec).
fib_dxr: do not leak memory if FIB constellation hits structural limit
May 17 2024, 4:47 PM
zec committed rG4ab122e8ef12: fib_dxr: check if cached fib_data matches the new request in dxr_init() (authored by zec).
fib_dxr: check if cached fib_data matches the new request in dxr_init()
May 17 2024, 4:23 PM

May 14 2024

zec committed rG9ae078121d3f: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
May 14 2024, 8:40 PM
zec committed rG354fa04f5ea1: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
May 14 2024, 8:40 PM
zec committed rG43571fe7c8dc: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
May 14 2024, 8:40 PM
zec committed rGf68ecf5d4fbd: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
May 14 2024, 8:40 PM
zec committed rG416679ecabd6: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
May 14 2024, 8:40 PM
zec committed rG2b9843e268fa: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
May 14 2024, 8:40 PM
zec committed rG40a1183ac774: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
May 14 2024, 8:40 PM
zec committed rG52075e4cfabc: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
May 14 2024, 8:39 PM
zec committed rG0418d7a09037: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
May 14 2024, 8:39 PM
zec committed rG1261fc325c3c: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
May 14 2024, 8:39 PM
zec committed rGe474704b9c49: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
May 14 2024, 8:39 PM
zec committed rGdf376a714af6: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
May 14 2024, 8:39 PM
zec committed rG64136682ba16: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
May 14 2024, 8:39 PM
zec committed rGe9927f4e6129: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
May 14 2024, 8:39 PM

May 7 2024

zec committed rGb24e353f9e58: fib_dxr: set fib_data field in struct dxr_aux early enough (authored by zec).
fib_dxr: set fib_data field in struct dxr_aux early enough
May 7 2024, 3:50 PM
zec committed rG4aa275f12da4: fib_dxr: s/KASSERT/MPASS/ (authored by zec).
fib_dxr: s/KASSERT/MPASS/
May 7 2024, 3:34 PM
zec committed rG7a5de1d4cc6a: fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects (authored by zec).
fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects
May 7 2024, 3:27 PM
zec committed rGed541e201a05: fib_dxr: move the bulko of malloc() failure logging into dxr_build() (authored by zec).
fib_dxr: move the bulko of malloc() failure logging into dxr_build()
May 7 2024, 3:13 PM

May 6 2024

zec committed rG5295e891d0d3: fib_dxr: update comment. (authored by zec).
fib_dxr: update comment.
May 6 2024, 6:43 PM
zec committed rG858010643c54: fib_dxr: free() does nothing if arg is NULL, so remove a redundant check. (authored by zec).
fib_dxr: free() does nothing if arg is NULL, so remove a redundant check.
May 6 2024, 6:39 PM
zec committed rG308caa38cdf5: fib_dxr: log malloc() failures. (authored by zec).
fib_dxr: log malloc() failures.
May 6 2024, 6:24 PM

Sep 23 2023

zec committed rG03ef737c544d: ng_eiface: switch VNETs when injecting mbufs into netgraph (authored by zec).
ng_eiface: switch VNETs when injecting mbufs into netgraph
Sep 23 2023, 9:25 AM

Jun 15 2023

zec committed rG32b28e3ae28f: route.8: mention DXR in FIB_ALGO section (authored by zec).
route.8: mention DXR in FIB_ALGO section
Jun 15 2023, 5:24 AM
zec added a reverting change for rGfb31ad53c471: route.8: mention DXR in FIB_ALGO section: rGfc17cf76153d: Back out fb31ad53c471e01ba473b2fb038c0cff6253654b, which was committed.
Jun 15 2023, 5:20 AM
zec committed rGfc17cf76153d: Back out fb31ad53c471e01ba473b2fb038c0cff6253654b, which was committed (authored by zec).
Back out fb31ad53c471e01ba473b2fb038c0cff6253654b, which was committed
Jun 15 2023, 5:20 AM

May 27 2023

zec committed rGfb31ad53c471: route.8: mention DXR in FIB_ALGO section (authored by zec).
route.8: mention DXR in FIB_ALGO section
May 27 2023, 8:33 AM

May 4 2022

zec committed rGc4585b938a04: tests: vnet tests started failing in CI, disable temporarily (authored by zec).
tests: vnet tests started failing in CI, disable temporarily
May 4 2022, 4:30 AM
zec closed D35119: Disable VNET tests on CI temporarily.
May 4 2022, 4:30 AM

May 3 2022

zec added a reverting change for rG91f44749c6fe: ifnet: make if_index global: rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global".
May 3 2022, 5:30 PM
zec committed rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global" (authored by zec).
VNET: Revert "ifnet: make if_index global"
May 3 2022, 5:30 PM
zec added a reverting change for rGe1882428dcbb: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:30 PM
zec added a reverting change for rG165746f4e4bf: dummynet: use m_rcvif_serialize/restore when queueing packets: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".
May 3 2022, 5:30 PM
zec added a reverting change for rG703e533da5e2: mbuf: do not restore dying interfaces: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:30 PM
zec added a reverting change for rG6871de9363e5: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs: rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs".
May 3 2022, 5:30 PM
zec added a reverting change for D33672: ifnet: make if_index global: rGd461deeaa4a4: VNET: Revert "ifnet: make if_index global".
May 3 2022, 5:29 PM
zec committed rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces" (authored by zec).
Revert "mbuf: do not restore dying interfaces"
May 3 2022, 5:29 PM
zec committed rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets" (authored by zec).
Revert "dummynet: use m_rcvif_serialize/restore when queueing packets"
May 3 2022, 5:29 PM
zec added a reverting change for D33266: ifnet/mbuf: provide KPI to serialize/restore m->m_pkthdr.rcvif: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:29 PM
zec added a reverting change for D34076: mbuf: do not restore dying interfaces: rG6c741ffbfa7f: Revert "mbuf: do not restore dying interfaces".
May 3 2022, 5:29 PM
zec committed rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs" (authored by zec).
Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs"
May 3 2022, 5:29 PM
zec committed rG711524d96123: tests/dummynet: disable since mbuf pointer serialization KPI to be backed out (authored by zec).
tests/dummynet: disable since mbuf pointer serialization KPI to be backed out
May 3 2022, 5:29 PM
zec added a reverting change for D33267: dummynet: use m_rcvif_serialize/restore when queueing packets: rG894c574ed2f2: Revert "dummynet: use m_rcvif_serialize/restore when queueing packets".
May 3 2022, 5:29 PM
zec added a reverting change for D33268: netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs: rG0fa5636966c9: Revert "netisr: serialize/restore m_pkthdr.rcvif when queueing mbufs".
May 3 2022, 5:29 PM

Mar 30 2022

zec requested changes to D34704: if: avoid interface destroy race.

This change builds on top if_index globalization (91f44749c6feb50f39af8805dd803e860f0418f1) which I strongly objected to, and which glebius agreed to back out as outlined in https://github.com/glebius/FreeBSD/commits/backout-ifindex, but that never happened. Hence, pls. don't proceed with this until if_index is reverted back to per-VNET state.

Mar 30 2022, 7:08 PM

Feb 6 2022

zec committed rGd055313f8c60: fib_algo: shift / mask by constants in dxr_lookup() (authored by zec).
fib_algo: shift / mask by constants in dxr_lookup()
Feb 6 2022, 7:35 AM

Jan 31 2022

zec added a watcher for network: zec.
Jan 31 2022, 10:43 PM

Jan 16 2022

zec committed rGe7abe200c27b: fib_algo: shift / mask by constants in dxr_lookup() (authored by zec).
fib_algo: shift / mask by constants in dxr_lookup()
Jan 16 2022, 11:32 PM

Oct 13 2021

zec committed rG602f81ea50d5: [fib_algo][dxr] Retire counters which are no longer used (authored by zec).
[fib_algo][dxr] Retire counters which are no longer used
Oct 13 2021, 8:10 PM
zec committed rG0eeef61aec4b: [fib_algo][dxr] Improve incremental updating strategy (authored by zec).
[fib_algo][dxr] Improve incremental updating strategy
Oct 13 2021, 8:10 PM

Oct 9 2021

zec committed rGbc8b8e106bd1: [fib_algo][dxr] Retire counters which are no longer used (authored by zec).
[fib_algo][dxr] Retire counters which are no longer used
Oct 9 2021, 11:54 AM
zec committed rG1549575f22d1: [fib_algo][dxr] Improve incremental updating strategy (authored by zec).
[fib_algo][dxr] Improve incremental updating strategy
Oct 9 2021, 11:38 AM

Sep 29 2021

zec committed rGc5981a8130e2: [fib_algo][dxr] Merge adjacent empty range table chunks. (authored by zec).
[fib_algo][dxr] Merge adjacent empty range table chunks.
Sep 29 2021, 8:44 PM
zec committed rG94ad8d7c7a35: [fib_algo][dxr] Split unused range chunk list in multiple buckets (authored by zec).
[fib_algo][dxr] Split unused range chunk list in multiple buckets
Sep 29 2021, 8:44 PM

Sep 25 2021

zec committed rG43880c511cef: [fib_algo][dxr] Split unused range chunk list in multiple buckets (authored by zec).
[fib_algo][dxr] Split unused range chunk list in multiple buckets
Sep 25 2021, 4:54 AM

Sep 20 2021

zec committed rG2ac039f7be62: [fib_algo][dxr] Merge adjacent empty range table chunks. (authored by zec).
[fib_algo][dxr] Merge adjacent empty range table chunks.
Sep 20 2021, 4:38 AM

Sep 18 2021

zec committed rGec47ee78b461: [fib algo][dxr] Fix division by zero. (authored by zec).
[fib algo][dxr] Fix division by zero.
Sep 18 2021, 5:41 PM
zec committed rGad2cca48ed53: [fib algo][dxr] Optimize trie updating. (authored by zec).
[fib algo][dxr] Optimize trie updating.
Sep 18 2021, 5:40 PM
zec committed rGd3b9b83623f2: [fib algo][dxr] Fix undefined behavior. (authored by zec).
[fib algo][dxr] Fix undefined behavior.
Sep 18 2021, 5:40 PM

Sep 16 2021

zec committed rGeb3148cc4d25: [fib algo][dxr] Fix division by zero. (authored by zec).
[fib algo][dxr] Fix division by zero.
Sep 16 2021, 2:44 PM

Sep 15 2021

zec committed rGb51f8bae570b: [fib algo][dxr] Optimize trie updating. (authored by zec).
[fib algo][dxr] Optimize trie updating.
Sep 15 2021, 8:50 PM
zec committed rG442c8a245ee3: [fib algo][dxr] Fix undefined behavior. (authored by zec).
[fib algo][dxr] Fix undefined behavior.
Sep 15 2021, 8:50 PM

Jun 20 2021

zec committed rG402ddb85eed2: Add IPv4 fib lookup performance tests with uniform keys. (authored by melifaro).
Add IPv4 fib lookup performance tests with uniform keys.
Jun 20 2021, 11:32 AM
zec committed rG09274116f4d9: tests: Revise FIB lookups per second benchmarking routines (authored by zec).
tests: Revise FIB lookups per second benchmarking routines
Jun 20 2021, 11:32 AM
zec committed rG2b6b8ea60cb5: Revise FIB lookups per second benchmarking routines. (authored by zec).
Revise FIB lookups per second benchmarking routines.
Jun 20 2021, 11:32 AM

Jun 17 2021

zec committed rG4715d948c593: Introduce DXR as an IPv4 longest prefix matching / FIB module (authored by zec).
Introduce DXR as an IPv4 longest prefix matching / FIB module
Jun 17 2021, 10:36 AM
zec committed rGb6f8436b094d: tests: Revise FIB lookups per second benchmarking routines (authored by zec).
tests: Revise FIB lookups per second benchmarking routines
Jun 17 2021, 6:52 AM

May 18 2021

zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 18 2021, 11:04 AM
zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 18 2021, 11:03 AM

May 17 2021

zec updated the summary of D30311: Revise FIB lookups per second benchmarking routines.
May 17 2021, 10:20 AM
zec added reviewers for D30311: Revise FIB lookups per second benchmarking routines: melifaro, olivier.
May 17 2021, 10:17 AM
zec requested review of D30311: Revise FIB lookups per second benchmarking routines.
May 17 2021, 10:16 AM

May 13 2021

zec accepted D28601: netgraph/ng_bridge: Avoid cache thrashing.
May 13 2021, 5:00 PM

May 8 2021

zec added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

function dxr_build with caller dxr_change_rib_batch seems to be still active

May 8 2021, 9:06 PM

May 5 2021

zec added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

...

I assume that it's another independent routing algo module and should be considered as full replacement, not any supplementation.

May 5 2021, 8:14 PM
zec committed rG2aca58e16f50: Introduce DXR as an IPv4 longest prefix matching / FIB module (authored by zec).
Introduce DXR as an IPv4 longest prefix matching / FIB module
May 5 2021, 11:48 AM
zec closed D29821: Introduce DXR IPv4 LPM as a fib_algo module..
May 5 2021, 11:48 AM
zec committed rGa43104ebe763: Revise FIB lookups per second benchmarking routines. (authored by zec).
Revise FIB lookups per second benchmarking routines.
May 5 2021, 10:34 AM
zec closed D30096: Revise FIB lookups per second benchmarking routines.
May 5 2021, 10:34 AM

May 4 2021

zec updated the diff for D30096: Revise FIB lookups per second benchmarking routines.

Simplify injection of artificial dependencies between successive lookups in an attempt to fool / defeat apparently nifty and mighty Ryzen's value predictors.

May 4 2021, 1:42 PM
zec added inline comments to D30096: Revise FIB lookups per second benchmarking routines.
May 4 2021, 10:24 AM

May 3 2021

zec updated the summary of D30096: Revise FIB lookups per second benchmarking routines.
May 3 2021, 10:28 PM