User Details
- User Since
- Apr 9 2015, 9:27 PM (548 w, 4 d)
Thu, Sep 18
Perfect, thank you. Should I wait for this to find it's way to FreeBSD or apply the change locally?
Tue, Sep 16
No need for a comment, I committed the following upstream:
Index: var.c =================================================================== RCS file: /cvsroot/src/usr.bin/make/var.c,v retrieving revision 1.1171 diff -u -p -r1.1171 var.c --- var.c 29 Jun 2025 11:02:17 -0000 1.1171 +++ var.c 16 Sep 2025 15:13:28 -0000 @@ -1850,7 +1850,7 @@ QuoteShell(const char *str, bool quoteDo static char * Hash(const char *str) { - static const char hexdigits[16] = "0123456789abcdef"; + static const char hexdigits[] = "0123456789abcdef"; const unsigned char *ustr = (const unsigned char *)str;
Mon, Sep 15
Sep 8 2025
Aug 21 2025
In case it isn't obvious, we can't stub or #ifdef this in libsa since that is presumably shared by all loaders for a given arch, thus a non-optional src from loader.mk would seem to make sense - misc.c seemed as good as any?
Aug 20 2025
Aug 8 2025
Aug 7 2025
Aug 5 2025
Aug 1 2025
Split out fs_ops.fs_flag to D51684
Jul 30 2025
Jul 25 2025
works for me, just one nit above
Note I would disagree that make isn't needed in a minimal install, I use make and makefiles for all sorts of use-cases that have nothing to do with building src/
Jul 24 2025
Jul 23 2025
Rework to avoid opening dirs via TFTP while not breaking diskless
boot with nfs.
I can't approved, but looks sane - I assume it works ;-)
Jul 22 2025
Jul 21 2025
Jul 20 2025
Jul 19 2025
Mention pkgfs_fsops in libsa.3
Jul 18 2025
Add flag to fs_ops for skipping devopen
This review has been broken up and the open review is D51187
Make the code in open() neater
Alternative means of skipping devopen for pkgfs
Jul 17 2025
Rebase after commit DEBUG_PRINTF
Jul 16 2025
Tweak the #ifdef in stand.h
Jul 11 2025
Jul 10 2025
Jul 9 2025
Tweak comment as suggested
Add a comment about why dev_cleanup needs to be called before bi_load
Jul 8 2025
Jul 6 2025
Jun 30 2025
Make the same change for arm, i386 and riscv
Jun 28 2025
Jun 5 2025
Jun 4 2025
Jun 3 2025
Update comment at start of host.test.mk
Jun 2 2025
May 27 2025
Give this a chance of being useful to non-DIRDEPS_BUILD
May 26 2025
May 22 2025
May 21 2025
May 20 2025
May 17 2025
Add host.test.mk to FILES
May 16 2025
Fix typo in log message
Fix typo in log message
May 15 2025
May 14 2025
A loader.efi with this change does not crash - but there is a long delay before the libsecureboot self tests output:
There are a number of bootinfo's that also getenv("rootdev")
May 13 2025
main also needs to double check for empty rootdev.