Page MenuHomeFreeBSD

sjg (Simon Gerraty)
User

Projects

User Details

User Since
Apr 9 2015, 9:27 PM (548 w, 4 d)

Recent Activity

Thu, Sep 18

sjg added a comment to D52563: bmake: Fix -Wunterminated-string-initialization.

Perfect, thank you. Should I wait for this to find it's way to FreeBSD or apply the change locally?

Thu, Sep 18, 8:17 PM

Tue, Sep 16

sjg added a comment to D52563: bmake: Fix -Wunterminated-string-initialization.

No need for a comment, I committed the following upstream:

Index: var.c
===================================================================
RCS file: /cvsroot/src/usr.bin/make/var.c,v
retrieving revision 1.1171
diff -u -p -r1.1171 var.c
--- var.c       29 Jun 2025 11:02:17 -0000      1.1171
+++ var.c       16 Sep 2025 15:13:28 -0000
@@ -1850,7 +1850,7 @@ QuoteShell(const char *str, bool quoteDo
 static char *
 Hash(const char *str)
 {
-       static const char hexdigits[16] = "0123456789abcdef";
+       static const char hexdigits[] = "0123456789abcdef";
        const unsigned char *ustr = (const unsigned char *)str;
Tue, Sep 16, 3:22 PM

Mon, Sep 15

sjg accepted D52420: crypto/openssl: apply polish to new vendor import process.
Mon, Sep 15, 10:09 PM

Sep 8 2025

sjg added inline comments to D52420: crypto/openssl: apply polish to new vendor import process.
Sep 8 2025, 5:02 AM

Aug 21 2025

sjg committed rG027be99b1f33: Stub is_tftp when LOADER_NET_SUPPORT is not enabled (authored by sjg).
Stub is_tftp when LOADER_NET_SUPPORT is not enabled
Aug 21 2025, 3:11 PM
sjg closed D52060: Stub is_tftp when LOADER_NET_SUPPORT is not enabled.
Aug 21 2025, 3:11 PM
sjg added a comment to D52060: Stub is_tftp when LOADER_NET_SUPPORT is not enabled.

In case it isn't obvious, we can't stub or #ifdef this in libsa since that is presumably shared by all loaders for a given arch, thus a non-optional src from loader.mk would seem to make sense - misc.c seemed as good as any?

Aug 21 2025, 6:52 AM
sjg requested review of D52060: Stub is_tftp when LOADER_NET_SUPPORT is not enabled.
Aug 21 2025, 6:40 AM

Aug 20 2025

sjg committed rG5bfb3045d25b: Allow secure-netboot (authored by sjg).
Allow secure-netboot
Aug 20 2025, 10:57 PM
sjg closed D51187: Allow secure-netboot.
Aug 20 2025, 10:56 PM
sjg committed rGb44cc1b479fe: loader: do not try to open directories with TFTP (authored by sjg).
loader: do not try to open directories with TFTP
Aug 20 2025, 10:49 PM
sjg closed D51447: loader: do not try to mount currdev for TFTP.
Aug 20 2025, 10:48 PM
sjg committed rGaaf65a13c06a: stand: add fs_ops.fs_flag (authored by sjg).
stand: add fs_ops.fs_flag
Aug 20 2025, 10:47 PM
sjg closed D51684: stand: add fs_ops.fs_flag.
Aug 20 2025, 10:47 PM

Aug 8 2025

sjg accepted D51824: mk: Mark buildenv .NOTMAIN.

Good move

Aug 8 2025, 4:58 PM

Aug 7 2025

sjg committed rG5c4d1c85847d: Replace license with just SPDX BSD-2-Clause (authored by sjg).
Replace license with just SPDX BSD-2-Clause
Aug 7 2025, 10:20 PM

Aug 5 2025

sjg committed rGb4894eca1ade: Merge bmake-20250804 (authored by sjg).
Merge bmake-20250804
Aug 5 2025, 10:59 PM
sjg committed rG787302bde4d8: Import bmake-20250804 (authored by sjg).
Import bmake-20250804
Aug 5 2025, 10:33 PM

Aug 1 2025

sjg updated the diff for D51187: Allow secure-netboot.

Split out fs_ops.fs_flag to D51684

Aug 1 2025, 5:39 PM
sjg requested review of D51684: stand: add fs_ops.fs_flag.
Aug 1 2025, 5:35 PM

Jul 30 2025

sjg added a comment to D51443: release/Makefile should not use the host /usr/bin/install command, but the freshly built one.

To make this work in cheribuild I passed INSTALL="sh /path/to/src/tools/install.sh". Doing something automatically here that works would be good, though I'd want confirmation from someone like @sjg that ${.OBJDIR}/.. is definitely going to always be world's ${OBJTOP}.

Jul 30 2025, 5:50 PM · releng

Jul 25 2025

sjg accepted D50149: do not commit - bmake: add a package for bmake and share/mk.

works for me, just one nit above

Jul 25 2025, 10:20 PM
sjg added a comment to D50149: do not commit - bmake: add a package for bmake and share/mk.

Note I would disagree that make isn't needed in a minimal install, I use make and makefiles for all sorts of use-cases that have nothing to do with building src/

Jul 25 2025, 9:45 PM

Jul 24 2025

sjg accepted D51490: bsd.man.mk: add MANGROUPS.

Looks reasonable

Jul 24 2025, 7:09 PM
sjg added inline comments to D51490: bsd.man.mk: add MANGROUPS.
Jul 24 2025, 4:35 PM
sjg added a comment to D51447: loader: do not try to mount currdev for TFTP.
In D51447#1175667, @imp wrote:

I do like this better...

But what we're trying to avoid is setting currdir to tftp://1.2.3.4/mumble and having lots of tftp traffic go as we try to open it a bunch of times to see if each of the filesystems can cope... Can you confirm that's the top of this rabbit hole?

Jul 24 2025, 12:53 AM

Jul 23 2025

sjg updated the diff for D51447: loader: do not try to mount currdev for TFTP.

Rework to avoid opening dirs via TFTP while not breaking diskless
boot with nfs.

Jul 23 2025, 10:57 PM
sjg accepted D51467: security/ossec-hids-local: fix makefile warnings: Invalid character " " in variable name.

I can't approved, but looks sane - I assume it works ;-)

Jul 23 2025, 5:53 AM

Jul 22 2025

sjg added inline comments to D51447: loader: do not try to mount currdev for TFTP.
Jul 22 2025, 10:56 PM

Jul 21 2025

sjg committed rGcae98cf683dd: install: allow ENV in metatags (authored by sjg).
install: allow ENV in metatags
Jul 21 2025, 5:15 PM
sjg closed D51446: install: allow ENV in metatags.
Jul 21 2025, 5:15 PM
sjg committed rG3717484168ee: bsd.subdir.mk skip _SUBDIR for DIRDEPS_BUILD (authored by sjg).
bsd.subdir.mk skip _SUBDIR for DIRDEPS_BUILD
Jul 21 2025, 4:13 PM
sjg closed D51454: bsd.subdir.mk skip _SUBDIR for DIRDEPS_BUILD.
Jul 21 2025, 4:12 PM
sjg requested review of D51454: bsd.subdir.mk skip _SUBDIR for DIRDEPS_BUILD.
Jul 21 2025, 3:58 PM

Jul 20 2025

sjg updated the diff for D51187: Allow secure-netboot.

Move install.c change to D51446
Move misc.c change to D51447

Jul 20 2025, 11:11 PM
sjg requested review of D51447: loader: do not try to mount currdev for TFTP.
Jul 20 2025, 11:06 PM
sjg requested review of D51446: install: allow ENV in metatags.
Jul 20 2025, 10:35 PM

Jul 19 2025

sjg updated the diff for D51187: Allow secure-netboot.

Mention pkgfs_fsops in libsa.3

Jul 19 2025, 8:58 PM
sjg committed rGa8c56be47166: Merge bmake-20250707 (authored by sjg).
Merge bmake-20250707
Jul 19 2025, 5:43 PM
sjg committed rG3d772e596c1a: Import bmake-20250707 (authored by sjg).
Import bmake-20250707
Jul 19 2025, 5:10 PM

Jul 18 2025

sjg updated the diff for D51187: Allow secure-netboot.

Add flag to fs_ops for skipping devopen

Jul 18 2025, 10:32 PM
sjg added inline comments to D51187: Allow secure-netboot.
Jul 18 2025, 10:12 PM
sjg abandoned D51094: Fix secure netboot with UEFI.

This review has been broken up and the open review is D51187

Jul 18 2025, 4:21 PM
sjg updated the diff for D51187: Allow secure-netboot.

Make the code in open() neater

Jul 18 2025, 4:09 PM
sjg updated the diff for D51187: Allow secure-netboot.

Alternative means of skipping devopen for pkgfs

Jul 18 2025, 12:58 AM
sjg added inline comments to D51187: Allow secure-netboot.
Jul 18 2025, 12:17 AM

Jul 17 2025

sjg updated the diff for D51187: Allow secure-netboot.

Rebase after commit DEBUG_PRINTF

Jul 17 2025, 11:54 PM
sjg committed rGe67aef419093: Add DEBUG_PRINTF to stand.h (authored by sjg).
Add DEBUG_PRINTF to stand.h
Jul 17 2025, 11:38 PM
sjg closed D51269: Add DEBUG_PRINTF to stand.h.
Jul 17 2025, 11:37 PM
sjg added a comment to D51269: Add DEBUG_PRINTF to stand.h.
In D51269#1173596, @imp wrote:

This looks good.

It would be nice if there was a loader command to set the debug level, but that's a separate thing and isn't universally useful since a lot of this code runs before the OK prompt.

Jul 17 2025, 11:36 PM
sjg added a comment to D51094: Fix secure netboot with UEFI.
In D51094#1172979, @imp wrote:

I had a note to follow up on this in a "little while"
Where are we? Is this review done? Or have I overlooked some sub-review that split off?

Jul 17 2025, 12:15 AM

Jul 16 2025

sjg updated the diff for D51269: Add DEBUG_PRINTF to stand.h.

Tweak the #ifdef in stand.h

Jul 16 2025, 12:22 AM

Jul 11 2025

sjg added a comment to D51187: Allow secure-netboot.
In D51187#1170063, @imp wrote:

Can you do the debug level stuff first so we get that out of the way? There's also a lot of different fixes bundled together which makes me super nervous for future bisecting...

Jul 11 2025, 10:38 PM
sjg requested review of D51269: Add DEBUG_PRINTF to stand.h.
Jul 11 2025, 10:36 PM

Jul 10 2025

sjg committed rGd1f0ee548c73: Allow net_cleanup for loader.efi (authored by sjg).
Allow net_cleanup for loader.efi
Jul 10 2025, 6:18 PM
sjg closed D51186: Allow net_cleanup for loader.efi.
Jul 10 2025, 6:17 PM

Jul 9 2025

sjg updated the diff for D51186: Allow net_cleanup for loader.efi.

Tweak comment as suggested

Jul 9 2025, 11:09 PM
sjg updated the diff for D51186: Allow net_cleanup for loader.efi.

Add a comment about why dev_cleanup needs to be called before bi_load

Jul 9 2025, 6:21 PM

Jul 8 2025

sjg added a comment to D51186: Allow net_cleanup for loader.efi.
In D51186#1169361, @imp wrote:
In D51186#1169123, @sjg wrote:
In D51186#1168883, @imp wrote:

So what happens when bi_load() returns an error? Most devices don't have the 'dv_cleanup()' routines, so it doesn't matter that much... But wouldn't this preclude network working if it does cleanup? I think it might be OK.

It looks like the only case for which bi_load() returns an error - vs panic is failure to find rootdev which seems the sort of thing that could have been done earlier?
If that were extracted to some earlier call, then bi_load() looks like a one way trip to boot or panic

It may be a redunant check. But I'm not sure that bi_load is the right place to do exit boot services since I don't want its callers to know that only panics are possible because that changes over time.

But I think your analysis is flawed, since we have

if (retry == 0) {
        BS->FreePages(addr, pages);
        printf("ExitBootServices error %lu\n", EFI_ERROR_CODE(status));
        return (EINVAL);
}

late in the bi_load.

Jul 8 2025, 11:55 PM
sjg added a comment to D51186: Allow net_cleanup for loader.efi.
In D51186#1168883, @imp wrote:

So what happens when bi_load() returns an error? Most devices don't have the 'dv_cleanup()' routines, so it doesn't matter that much... But wouldn't this preclude network working if it does cleanup? I think it might be OK.

Jul 8 2025, 5:16 PM
sjg added a comment to D51186: Allow net_cleanup for loader.efi.
In D51186#1168883, @imp wrote:

So what happens when bi_load() returns an error? Most devices don't have the 'dv_cleanup()' routines, so it doesn't matter that much... But wouldn't this preclude network working if it does cleanup? I think it might be OK.

Jul 8 2025, 5:02 PM

Jul 6 2025

sjg requested review of D51187: Allow secure-netboot.
Jul 6 2025, 11:54 PM
sjg added a comment to D51094: Fix secure netboot with UEFI.
In D51094#1168500, @imp wrote:

Usually many of the smaller changes will go in quickly if there are any others the prove to need more discussion. So that can also narrow the focus quickly. Thanks.

Jul 6 2025, 11:53 PM
sjg requested review of D51186: Allow net_cleanup for loader.efi.
Jul 6 2025, 11:35 PM
sjg added a comment to D51094: Fix secure netboot with UEFI.
In D51094#1168160, @imp wrote:

This mixes a lot of different types of changes all in one big ball that's hard to review.
Any chance you could break them down to approximately what the paragraphs of the description say? At the very least, the debug stuff should be a separate commit, but really there's about 10 commits hiding in this one review by my quick count. It makes bisecting quite a bit simpler to do separate commits.

Jul 6 2025, 11:23 PM

Jun 30 2025

sjg updated the diff for D51094: Fix secure netboot with UEFI.

Make the same change for arm, i386 and riscv

Jun 30 2025, 9:31 PM
sjg requested review of D51094: Fix secure netboot with UEFI.
Jun 30 2025, 6:01 PM

Jun 28 2025

sjg committed rG0b46a53a2f50: Merge bmake-20250618 (authored by sjg).
Merge bmake-20250618
Jun 28 2025, 2:53 AM
sjg committed rG4f8f2bc29466: Import bmake-20250618 (authored by sjg).
Import bmake-20250618
Jun 28 2025, 2:39 AM

Jun 5 2025

sjg committed rGac05fc395317: local.dirdeps.mk remove stray .endif (authored by sjg).
local.dirdeps.mk remove stray .endif
Jun 5 2025, 3:37 AM
sjg committed rGbf407f36c5e9: local.dirdeps.mk move MK_RUN_TESTS .endif (authored by sjg).
local.dirdeps.mk move MK_RUN_TESTS .endif
Jun 5 2025, 3:31 AM

Jun 4 2025

sjg committed rG8e1e989c77d4: Add host.test.mk for DIRDEPS_BUILD (authored by sjg).
Add host.test.mk for DIRDEPS_BUILD
Jun 4 2025, 7:59 PM
sjg closed D50387: Add host.test.mk for DIRDEPS_BUILD.
Jun 4 2025, 7:59 PM

Jun 3 2025

sjg updated the diff for D50387: Add host.test.mk for DIRDEPS_BUILD.

Update comment at start of host.test.mk

Jun 3 2025, 8:06 PM
sjg committed rGa40d73475b1d: Export SB_OBJROOT for later reference (authored by sjg).
Export SB_OBJROOT for later reference
Jun 3 2025, 7:57 PM
sjg closed D50313: Export SB_OBJROOT for later reference.
Jun 3 2025, 7:57 PM

Jun 2 2025

sjg committed rG61d77e6c0095: loader: allow for exceptions to restricted settings. (authored by sjg).
loader: allow for exceptions to restricted settings.
Jun 2 2025, 5:50 AM
sjg committed rGf9890204b5db: install: must set netproto for tftp:// (authored by sjg).
install: must set netproto for tftp://
Jun 2 2025, 5:30 AM

May 27 2025

sjg updated the diff for D50387: Add host.test.mk for DIRDEPS_BUILD.

Give this a chance of being useful to non-DIRDEPS_BUILD

May 27 2025, 11:36 PM

May 26 2025

sjg committed rGb0ada425efb3: safe_eval allow : and + in values (authored by sjg).
safe_eval allow : and + in values
May 26 2025, 3:07 AM

May 22 2025

sjg committed rG2982c7085239: stand allow for local.defs.mk (authored by sjg).
stand allow for local.defs.mk
May 22 2025, 10:49 PM
sjg closed D50478: stand allow for local.defs.mk.
May 22 2025, 10:48 PM
sjg added inline comments to D50478: stand allow for local.defs.mk.
May 22 2025, 10:46 PM
sjg requested review of D50478: stand allow for local.defs.mk.
May 22 2025, 9:41 PM

May 21 2025

sjg added a comment to D50459: release: Avoid pipe in tarball creation.

Is there a reasonable way to have make use bash as the default shell on Linux?

May 21 2025, 8:27 PM
sjg added a comment to D50459: release: Avoid pipe in tarball creation.

What shell are we using here, the default system sh? dash doesn't support pipefail, so I'm concerned this will break on Linux.

May 21 2025, 8:09 PM

May 20 2025

sjg committed rG41cf74fe8ce5: loader - guard against empty rootdev (authored by sjg).
loader - guard against empty rootdev
May 20 2025, 4:13 PM
sjg closed D50334: loader - guard against empty rootdev.
May 20 2025, 4:12 PM

May 17 2025

sjg updated the diff for D50313: Export SB_OBJROOT for later reference.

tweak

May 17 2025, 3:34 PM
sjg updated the diff for D50387: Add host.test.mk for DIRDEPS_BUILD.

Add host.test.mk to FILES

May 17 2025, 3:12 PM

May 16 2025

sjg committed rG496b3c3a1ce8: grantbylabel_syscall check p_textvp != NULL (authored by sjg).
grantbylabel_syscall check p_textvp != NULL
May 16 2025, 10:20 PM
sjg closed D50368: grantbylabel_syscall check p_textvp != NULL.
May 16 2025, 10:20 PM
sjg updated the diff for D50313: Export SB_OBJROOT for later reference.

Fix typo in log message

May 16 2025, 9:22 PM
sjg updated the diff for D50387: Add host.test.mk for DIRDEPS_BUILD.

Fix typo in log message

May 16 2025, 9:17 PM
sjg requested review of D50387: Add host.test.mk for DIRDEPS_BUILD.
May 16 2025, 9:15 PM

May 15 2025

sjg requested review of D50368: grantbylabel_syscall check p_textvp != NULL.
May 15 2025, 5:16 PM

May 14 2025

sjg added a comment to D50334: loader - guard against empty rootdev.

A loader.efi with this change does not crash - but there is a long delay before the libsecureboot self tests output:

May 14 2025, 4:06 PM
sjg added a comment to D50334: loader - guard against empty rootdev.

There are a number of bootinfo's that also getenv("rootdev")

May 14 2025, 12:36 AM

May 13 2025

sjg updated the diff for D50334: loader - guard against empty rootdev.

main also needs to double check for empty rootdev.

May 13 2025, 6:29 PM
sjg added a comment to D50334: loader - guard against empty rootdev.
In D50334#1148471, @imp wrote:

I don't object, but I'd like more details about how this comes to pass

May 13 2025, 6:28 PM