In D47478#1098572, @leres wrote:

Even with the "Approved by" header "arc land" still gives me 403 (as does "git push").

• better test for more than one pattern

Even with the "Approved by" header "arc land" still gives me 403 (as does "git push").

consolidate commits after (failed) attempts to run "arc land"

When I started today, the phabricator (returning either 502 bad gateway, a broken page, or a correct looking page that wouldn't let me post a comment). I decided it would be best to wait for that to resolve...

In D47478#1098397, @dim wrote:

I think normally arc land adds Reviewed by:, but it doesn't make too much difference I guess.

In D47478#1098383, @dim wrote:

Oh actually @leres can commit this :)

In D47478#1097722, @jrtc27 wrote:

That’s definitely a build of main? That looks to me more like GPL dialog than bsddialog.

In D47478#1097625, @jhb wrote:

So I wonder what the dialog looks like now by default on an 80x25 console? Does bsddialog do something sane to truncate the option list if it is too long or does it render oddly?

Address review feedback:
Show ZFSBOOT_POOL_CREATE_OPTIONS in main menu.
Remove extraneous blank in message.

I tried putting the options in the menu but I was worried they would quickly get too wide. But I guess if the options are too wide to view the user can make the window wider

(And I don't think we need to worry about input width; dialog seems to do a good job of dealing when the contents of the input box is large, you can use arrow keys to scroll left and right.)

In D47478#1097126, @jhb wrote:

It might nice if this showed the current options or is that potentially too large?

(I don't know how to render the handbook but) the text in this change solves my concerns.