Remove is_admin = false in ufshci_ctrlr_submit_task_mgmt_request

Thank you!

Thank you for fixing this!

After this fix, the following two reviews have been rebased and are ready for approval:
https://reviews.freebsd.org/D54003
https://reviews.freebsd.org/D54004

rebase

rebase

Use device_suspend/device_resume

In D53375#1233119, @imp wrote:

OK. I understand adding the quirk. It may make sense for us to handle some of these 'probing' commands better in the future, but we have many others than the ones you've added. As such, lets go wit the the PIM_WLUN flag for now.

I'm sorry for being late. I completely forgot.

Reopen until the current comment is resolved.

Please approve this review again. Sorry for confusion.

This review has been split into the following 5 reviews. Please check the following reviews.
Sorry for the confusion.

Please accept again same commit: https://reviews.freebsd.org/D53919

• cam/scsi: Support well known logical unit
• ufshci: Enable WLUN scan
• cam/scsi: Add power condition support to START STOP UNIT
• ufshci: Add a check for WLUN during driver initialization

Thanks for the review~!

Oh, you left a review here. I'll reopen it.

We'll review each patch individually.
https://reviews.freebsd.org/D53376

This patch is ready for the review!

I will request a review for each commit individually to make reviewing easier.

In D52440#1198791, @imp wrote:

So this change is a bit larger than I like to review. But the moved code was simple (and I know I have comment about the moved code, and that maybe the NVMe driver isn't good about doing it true). In the future, though it would make it easiest if you had the 'move it' commits separate from the rest. The place I want a comment could get one later too, if that's easier to do.

Looking at the recovery algorithm, it does seem quite similar to the NVMe one. The only concern I have here is that we'll need to track it in two places. I've been tweaking it from time to time in the nvme driver, but I don't know how applicable future tweaks will be. I guess this is more of a "be aware" in the future comment.

Add a comment

update commit log

Fix queue contruct sequence

I expected the timeout handling to be in the CAM, but it seems the CAM only performs a retry and does not execute cmd abort and controller reset. Therefore, I implemented the cmd abort and controller reset within the ufshci driver. Is my understanding correct?

Added some comments for reviewers.

fix indent

add a newline at end of file

In D51893#1193102, @imp wrote:

One question, and one minor problem... Otherwise, I think this is fine. It's a feature that's enable on attach and then everything about it happens automatically, right?

rebase to the head