Page MenuHomeFreeBSD

ufshci: Support suspend/resume
ClosedPublic

Authored by jaeyoon on Mon, Dec 1, 6:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 19, 9:50 AM
Unknown Object (File)
Sun, Dec 14, 9:46 PM
Unknown Object (File)
Sat, Dec 13, 10:23 PM
Unknown Object (File)
Sat, Dec 13, 8:17 AM
Unknown Object (File)
Wed, Dec 10, 8:36 PM
Unknown Object (File)
Wed, Dec 10, 5:25 PM
Unknown Object (File)
Tue, Dec 9, 6:11 PM
Unknown Object (File)
Tue, Dec 9, 7:22 AM
Subscribers
None

Details

Summary

Handle system power events and issue START STOP UNIT (SSU) to the
UFS Device WLUN (0x50).

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jaeyoon created this revision.

Looks generally good, but I did have one question...

sys/dev/ufshci/ufshci.c
54 ↗(On Diff #167345)

Is there a reason that you didn't do this in a device_suspend/device_resume function?

sys/dev/ufshci/ufshci.c
54 ↗(On Diff #167345)

Oh... I realize I misunderstood this.
You’re right! This should be handled via device_suspend/device_resume.
I’ll fix the implementation and send a revised patch for review.

Use device_suspend/device_resume

After this fix, the following two reviews have been rebased and are ready for approval:
https://reviews.freebsd.org/D54003
https://reviews.freebsd.org/D54004

This revision is now accepted and ready to land.Wed, Dec 3, 12:44 AM
This revision was automatically updated to reflect the committed changes.