Page MenuHomeFreeBSD
Differential D54002

ufshci: Support suspend/resume
ClosedPublic
Actions

Authored by jaeyoon on Mon, Dec 1, 6:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 19, 9:50 AM
Unknown Object (File)
Sun, Dec 14, 9:46 PM
Unknown Object (File)
Sat, Dec 13, 10:23 PM
Unknown Object (File)
Sat, Dec 13, 8:17 AM
Unknown Object (File)
Wed, Dec 10, 8:36 PM
Unknown Object (File)
Wed, Dec 10, 5:25 PM
Unknown Object (File)
Tue, Dec 9, 6:11 PM
Unknown Object (File)
Tue, Dec 9, 7:22 AM
View All 12 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG3a99f31fdb6c: ufshci: Support suspend/resume
Summary

Handle system power events and issue START STOP UNIT (SSU) to the
UFS Device WLUN (0x50).

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jaeyoon requested review of this revision.Mon, Dec 1, 6:47 AM
jaeyoon created this revision.
Harbormaster completed remote builds in B68947: Diff 167345.Mon, Dec 1, 6:47 AM
jaeyoon added a child revision: D54003: ufshci: Support UIC hibernation enter/exit.Mon, Dec 1, 6:47 AM
imp added a comment.Tue, Dec 2, 4:27 AM

Looks generally good, but I did have one question...

sys/dev/ufshci/ufshci.c
54 ↗(On Diff #167345)

Is there a reason that you didn't do this in a device_suspend/device_resume function?

jaeyoon added inline comments.Tue, Dec 2, 5:16 AM
sys/dev/ufshci/ufshci.c
54 ↗(On Diff #167345)

Oh... I realize I misunderstood this.
You’re right! This should be handled via device_suspend/device_resume.
I’ll fix the implementation and send a revised patch for review.

jaeyoon updated this revision to Diff 167413.Tue, Dec 2, 7:41 AM

Use device_suspend/device_resume

Harbormaster completed remote builds in B68990: Diff 167413.Tue, Dec 2, 7:42 AM
jaeyoon added a comment.Tue, Dec 2, 7:49 AM

After this fix, the following two reviews have been rebased and are ready for approval:
https://reviews.freebsd.org/D54003
https://reviews.freebsd.org/D54004

imp accepted this revision.Wed, Dec 3, 12:44 AM
This revision is now accepted and ready to land.Wed, Dec 3, 12:44 AM
Closed by commit rG3a99f31fdb6c: ufshci: Support suspend/resume (authored by jaeyoon). · Explain WhyWed, Dec 3, 4:06 AM
This revision was automatically updated to reflect the committed changes.
jaeyoon added a commit: rG3a99f31fdb6c: ufshci: Support suspend/resume.

Revision Contents
Changeset List

PathSize
sys/
dev/
ufshci/
50 lines
19 lines
23 lines
35 lines
3 lines
7 lines
3 lines

Diff 167457

View Options

sys/dev/ufshci/ufshci_ctrlr.c

Loading...
View Options

sys/dev/ufshci/ufshci_dev.c

Loading...
View Options

sys/dev/ufshci/ufshci_pci.c

Loading...
View Options

sys/dev/ufshci/ufshci_private.h

Loading...
View Options

sys/dev/ufshci/ufshci_req_queue.c

Loading...
View Options

sys/dev/ufshci/ufshci_sim.c

Loading...
View Options

sys/dev/ufshci/ufshci_sysctl.c

Loading...