Well, I'm not sure. It's not completely useless. It helped me to discover few bugs during development. Maybe we could keep it just for now when there is no better testing employed. Filtering those information out itself could be considered a check because if a string doesn't match the regular expression, it's not filtered out and it's detected. Please, decide. If you close this review (and the one for ping6), I will understand and I will continue without the ATF sh tests.

Use a single tab width in the ATF test script.

Use a single tab width in the ATF test script.

Yes.

It seems that that are far more variable parts in the output than I thought. I think the exact ttl value and ordering of responses cannot be relied on either. Is it OK having a test like this with all of that numeric information filetered out?

Could I use getaddrinfo command for that? Like this:

Use copyright information and ID from ping.c in utils.c.

Remove WARNS. 6 is the default level.

Should I put any copyright information to tests/ping_test.sh?

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

Document dnsdecode's arguments and return value.

All of the warnings should be fixed (D21269, D21270, D21271, D21273, D21275).

This depends on D21217.

Rebase to the master branch.

Thanks for the fix.

Use timespecadd(), and timespecsub().

Use timespecadd(), timespecsub(), and timespecclear().

The revision has been combined.

Annotate truncating of time values saved in a packet.

Use timespecsub(3) instead of a private function.

What should be the correct description?

Try to Use arc diff so that all the changes are included in the diff.

Limit stdio rights.

Use nitems() for getting size of an array.

Define two separate cap_rights_t sets, one for each socket, and use cap_rights_clear() to remove CAP_SETSOCKOPT before further limiting rights on those sockets.

In D21050#456890, @markj wrote:

There are some seemingly unrelated changes: we drop privileges earlier, we set SO_DEBUG on both sockets, some whitespace changes. I would suggest having those be separate commits.