Page MenuHomeFreeBSD
Differential D21266

ping6: Fix dnsdecode() bug introduced by r350859
ClosedPublic
Actions

Authored by jansucan on Aug 15 2019, 7:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 12:08 PM
Unknown Object (File)
Mon, Nov 11, 2:32 PM
Unknown Object (File)
Sun, Oct 27, 6:10 AM
Unknown Object (File)
Oct 8 2024, 4:32 AM
Unknown Object (File)
Sep 25 2024, 3:47 PM
Unknown Object (File)
Sep 24 2024, 9:13 AM
Unknown Object (File)
Sep 23 2024, 4:49 PM
Unknown Object (File)
Sep 21 2024, 3:24 AM
View All 61 Files
Subscribers
imp

Details

Reviewers
asomers
Commits
rS351170: ping6: Fix dnsdecode() bug introduced by r350859
Summary

Fix dnsdecode() bug introduced by r350859

r350859 removed level of indirection that was needed for setting the
caller's `cp' pointer. dnsdecode() uses return value to indicate error
or success. It returns pointer to a buffer holding a decompressed DNS
name or NULL. The caller uses that value only to find out the result,
not for accessing the buffer.

We use the return value to propagate the new value of `cp' pointer to
the caller instead of using an output argument.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jansucan created this revision.Aug 15 2019, 7:20 AM
Harbormaster completed remote builds in B25881: Diff 60819.Aug 15 2019, 7:20 AM
asomers added inline comments.Aug 15 2019, 3:12 PM
sbin/ping6/ping6.c
1431 ↗(On Diff #60819)

Since you're here, could you document dnsdecode's arguments and return value?

jansucan updated this revision to Diff 60871.Aug 16 2019, 6:45 AM

Document dnsdecode's arguments and return value.

Harbormaster completed remote builds in B25909: Diff 60871.Aug 16 2019, 6:45 AM
jansucan added inline comments.Aug 16 2019, 6:49 AM
sbin/ping6/ping6.c
1431 ↗(On Diff #60819)

Fixed. However, I'm a bit unsure about the RFC because the function doesn't seem to follow it completely.

asomers accepted this revision.Aug 17 2019, 2:21 PM
This revision is now accepted and ready to land.Aug 17 2019, 2:21 PM
Closed by commit rS351170: ping6: Fix dnsdecode() bug introduced by r350859 (authored by asomers). · Explain WhyAug 17 2019, 2:28 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS351170: ping6: Fix dnsdecode() bug introduced by r350859.
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2019, 2:28 PM
asomers mentioned this in rS351964: MFC r350858-r350859, r350987, r351170.Sep 6 2019, 8:16 PM

Revision Contents
Changeset List

PathSize
head/
sbin/
ping6/
38 lines

Diff 60942

View Options

head/sbin/ping6/ping6.c

Loading...