Page MenuHomeFreeBSD

ping6: Consistently use the byteorder functions in the correct direction
ClosedPublic

Authored by sucanjan_gmail.com on Mon, Aug 12, 7:03 AM.

Details

Summary

Consistently use the byteorder functions in the correct direction

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

The description of this review isn't really correct. Since ntohs and htons have identical effects, you aren't making any change to the endianness of the sequence number on the wire. The change is more stylistic, really.

What should be the correct description?

Maybe something like "consistently use the byteorder functions in the correct direction"?

sucanjan_gmail.com retitled this revision from ping6: Fix endianness of a sequence number in a packet to send to ping6: Consistently use the byteorder functions in the correct direction.Tue, Aug 13, 7:23 AM
sucanjan_gmail.com edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.