Page MenuHomeFreeBSD

ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)
ClosedPublic

Authored by sucanjan_gmail.com on Aug 12 2019, 11:53 AM.

Details

Summary

Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers requested changes to this revision.Aug 12 2019, 7:34 PM

Thanks for fixing this. This will be a good change.

sbin/ping6/ping6.c
2218 ↗(On Diff #60673)

You should eliminate this function and use timespecsub(3) instead.

This revision now requires changes to proceed.Aug 12 2019, 7:34 PM

Use timespecsub(3) instead of a private function.

sbin/ping6/ping6.c
2218 ↗(On Diff #60673)

Fixed.

Annotate truncating of time values saved in a packet.

asomers requested changes to this revision.Aug 13 2019, 3:10 PM
asomers added inline comments.
sbin/ping6/ping6.c
1151 ↗(On Diff #60714)

These 10 lines can be replaced by timespecadd.

This revision now requires changes to proceed.Aug 13 2019, 3:10 PM

Use timespecadd(), timespecsub(), and timespecclear().

sbin/ping6/ping6.c
1151 ↗(On Diff #60714)

Fixed.

asomers accepted this revision.Aug 13 2019, 7:22 PM
asomers added inline comments.
sbin/ping6/ping6.c
1151 ↗(On Diff #60714)

Thanks. It's much more readable now.

This revision is now accepted and ready to land.Aug 13 2019, 7:22 PM
This revision was automatically updated to reflect the committed changes.