Page MenuHomeFreeBSD

ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)
ClosedPublic

Authored by jansucan on Aug 12 2019, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 11:46 AM
Unknown Object (File)
Sat, Mar 16, 11:46 AM
Unknown Object (File)
Sat, Mar 16, 11:46 AM
Unknown Object (File)
Sun, Mar 3, 12:49 PM
Unknown Object (File)
Feb 27 2024, 12:06 AM
Unknown Object (File)
Jan 11 2024, 6:26 AM
Unknown Object (File)
Jan 7 2024, 1:47 AM
Unknown Object (File)
Jan 7 2024, 1:06 AM
Subscribers

Details

Summary

Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25826
Build 24398: arc lint + arc unit

Event Timeline

asomers requested changes to this revision.Aug 12 2019, 7:34 PM

Thanks for fixing this. This will be a good change.

sbin/ping6/ping6.c
2216–2217

You should eliminate this function and use timespecsub(3) instead.

This revision now requires changes to proceed.Aug 12 2019, 7:34 PM

Use timespecsub(3) instead of a private function.

sbin/ping6/ping6.c
2216–2217

Fixed.

Annotate truncating of time values saved in a packet.

asomers requested changes to this revision.Aug 13 2019, 3:10 PM
asomers added inline comments.
sbin/ping6/ping6.c
1151

These 10 lines can be replaced by timespecadd.

This revision now requires changes to proceed.Aug 13 2019, 3:10 PM

Use timespecadd(), timespecsub(), and timespecclear().

sbin/ping6/ping6.c
1151

Fixed.

asomers added inline comments.
sbin/ping6/ping6.c
1151

Thanks. It's much more readable now.

This revision is now accepted and ready to land.Aug 13 2019, 7:22 PM