Page MenuHomeFreeBSD
Differential D21226

ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)
ClosedPublic
Actions

Authored by jansucan on Aug 12 2019, 11:53 AM.
Tags
None
Referenced Files
F170793159: D21226.id60673.diff
Sun, Sep 6, 4:09 PM
Unknown Object (File)
Sun, Sep 6, 1:20 PM
Unknown Object (File)
Sun, Sep 6, 4:55 AM
Unknown Object (File)
Sat, Sep 5, 6:02 PM
Unknown Object (File)
Sat, Sep 5, 3:49 AM
Unknown Object (File)
Fri, Sep 4, 5:01 AM
Unknown Object (File)
Thu, Sep 3, 10:22 AM
Unknown Object (File)
Wed, Sep 2, 4:25 AM
View All Files
Subscribers
imp

Details

Reviewers
asomers
Commits
rS350997: ping6: use the monotonic clock to measure durations
Summary

Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC)

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25825
Build 24397: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 12 2019, 11:53 AM
Harbormaster completed remote builds in B25801: Diff 60673.Aug 12 2019, 11:53 AM
jansucan mentioned this in D21217: ping6: Fix alignment errors.Aug 12 2019, 11:55 AM
asomers requested changes to this revision.Aug 12 2019, 7:34 PM

Thanks for fixing this. This will be a good change.

sbin/ping6/ping6.c
2210–2211

You should eliminate this function and use timespecsub(3) instead.

This revision now requires changes to proceed.Aug 12 2019, 7:34 PM
jansucan updated this revision to Diff 60713.Aug 13 2019, 7:05 AM

Use timespecsub(3) instead of a private function.

Harbormaster completed remote builds in B25825: Diff 60713.Aug 13 2019, 7:05 AM
jansucan added inline comments.Aug 13 2019, 7:06 AM
sbin/ping6/ping6.c
2210–2211

Fixed.

jansucan updated this revision to Diff 60714.Aug 13 2019, 7:13 AM

Annotate truncating of time values saved in a packet.

Harbormaster completed remote builds in B25826: Diff 60714.Aug 13 2019, 7:13 AM
asomers requested changes to this revision.Aug 13 2019, 3:10 PM
asomers added inline comments.
sbin/ping6/ping6.c
1151–1153

These 10 lines can be replaced by timespecadd.

This revision now requires changes to proceed.Aug 13 2019, 3:10 PM
asomers mentioned this in D21220: ping6: Annotate truncating of time values saved in a packet.Aug 13 2019, 4:26 PM
jansucan updated this revision to Diff 60744.Aug 13 2019, 5:24 PM

Use timespecadd(), timespecsub(), and timespecclear().

Harbormaster completed remote builds in B25844: Diff 60744.Aug 13 2019, 5:24 PM
jansucan added inline comments.Aug 13 2019, 5:25 PM
sbin/ping6/ping6.c
1151–1153

Fixed.

asomers accepted this revision.Aug 13 2019, 7:22 PM
asomers added inline comments.
sbin/ping6/ping6.c
1151–1153

Thanks. It's much more readable now.

This revision is now accepted and ready to land.Aug 13 2019, 7:22 PM
Closed by commit rS350997: ping6: use the monotonic clock to measure durations (authored by asomers). · Explain WhyAug 13 2019, 7:24 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS350997: ping6: use the monotonic clock to measure durations.
Herald added a subscriber: imp. · View Herald TranscriptAug 13 2019, 7:24 PM
asomers mentioned this in rS352232: MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102.Sep 11 2019, 8:13 PM

Revision Contents
Changeset List

PathSize
sbin/
ping6/
81 lines

Diff 60713

View Options

sbin/ping6/ping6.c

Loading...