Page MenuHomeFreeBSD

ping: move in_cksum() to a separate source file
ClosedPublic

Authored by sucanjan_gmail.com on Aug 16 2019, 7:20 AM.

Details

Summary

Move in_cksum() to a separate source file

This is a preparation step for adding ATF tests of in_cksum(), which
has been modified to operate on unaligned data. ping.o cannot be
linked to the test executable because both of them contain 'main'
symbol.

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

A safe bet is to use the whole copyright notice from ping.c.

asomers requested changes to this revision.Aug 17 2019, 2:41 PM

As Ryan said, utils.c needs a copyright header. it also needs a $FreeBSD$ keyword.

This revision now requires changes to proceed.Aug 17 2019, 2:41 PM
sucanjan_gmail.com retitled this revision from ping6: move in_cksum() to a separate source file to ping: move in_cksum() to a separate source file.Aug 17 2019, 3:14 PM

Use copyright information and ID from ping.c in utils.c.

asomers accepted this revision.Aug 17 2019, 3:23 PM
This revision is now accepted and ready to land.Aug 17 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.