Page MenuHomeFreeBSD

ping: increase buffer size for the string representation of n_time
ClosedPublic

Authored by jansucan on Aug 19 2019, 4:59 PM.
Tags
None
Referenced Files
F162434885: D21325.diff
Mon, Jul 13, 6:04 AM
Unknown Object (File)
Sat, Jun 27, 7:42 AM
Unknown Object (File)
Mon, Jun 15, 3:13 PM
Unknown Object (File)
Mon, Jun 15, 3:13 PM
Unknown Object (File)
Jun 9 2026, 3:30 AM
Unknown Object (File)
Jun 7 2026, 1:38 AM
Unknown Object (File)
May 17 2026, 2:06 AM
Unknown Object (File)
May 16 2026, 11:11 PM
Subscribers

Details

Summary

Increase buffer size for the string representation of n_time

This fixes -Wformat-truncation warning when compiled with GCC.

ICMP timestamp is a 32-bit number. In pr_ntime(), number of minutes
and seconds is always 2 characters wide. Max. number of hours is 4
characters wide. The buffer size should be at least:

4 + 2 + 2 + 1 (':') + 1 (':') + 1 ('\0') = 11

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable