Page MenuHomeFreeBSD

ping: increase buffer size for the string representation of n_time
ClosedPublic

Authored by jansucan on Aug 19 2019, 4:59 PM.
Tags
None
Referenced Files
F148303458: D21325.id61002.diff
Tue, Mar 17, 1:55 AM
F148303449: D21325.id61002.diff
Tue, Mar 17, 1:55 AM
Unknown Object (File)
Sun, Mar 15, 12:40 PM
Unknown Object (File)
Fri, Mar 6, 6:40 AM
Unknown Object (File)
Sun, Mar 1, 2:18 AM
Unknown Object (File)
Jan 18 2026, 4:40 PM
Unknown Object (File)
Jan 17 2026, 1:10 PM
Unknown Object (File)
Jan 17 2026, 12:07 PM
Subscribers

Details

Summary

Increase buffer size for the string representation of n_time

This fixes -Wformat-truncation warning when compiled with GCC.

ICMP timestamp is a 32-bit number. In pr_ntime(), number of minutes
and seconds is always 2 characters wide. Max. number of hours is 4
characters wide. The buffer size should be at least:

4 + 2 + 2 + 1 (':') + 1 (':') + 1 ('\0') = 11

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable