Page MenuHomeFreeBSD

ping: increase buffer size for the string representation of n_time
ClosedPublic

Authored by jansucan on Aug 19 2019, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 8:02 PM
Unknown Object (File)
Tue, Sep 30, 6:02 PM
Unknown Object (File)
Mon, Sep 22, 6:32 PM
Unknown Object (File)
Mon, Sep 22, 6:16 PM
Unknown Object (File)
Mon, Sep 22, 6:15 PM
Unknown Object (File)
Sun, Sep 21, 4:43 AM
Unknown Object (File)
Sat, Sep 20, 11:50 PM
Unknown Object (File)
Sun, Sep 14, 9:19 PM
Subscribers

Details

Summary

Increase buffer size for the string representation of n_time

This fixes -Wformat-truncation warning when compiled with GCC.

ICMP timestamp is a 32-bit number. In pr_ntime(), number of minutes
and seconds is always 2 characters wide. Max. number of hours is 4
characters wide. The buffer size should be at least:

4 + 2 + 2 + 1 (':') + 1 (':') + 1 ('\0') = 11

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable