In D37013#975931, @cy wrote:LGTM.
Prior to commit, can I please have your full name and email address so that I can fill in the --author field?
The subject line and summary have been adjusted to make for a good commit log message.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 28 2023
Nov 28 2023
Nov 27 2023
Nov 27 2023
firk_cantconnect.ru retitled D37012: math/mpfr: Add INFO option from Add INFO option to math/mpfr to get rid of unconditional texinfo dependency to math/mpfr: Add INFO option.
In D37013#975891, @cy wrote:===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/info/ctf-spec.info Error: Orphaned: share/info/sframe-spec.info ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/devel/binutils
fix unwanted info files when INFO disabled
In D37013#975828, @cy wrote:/tmp/D37013.diff:50: space before tab in indent.
$(MAKE) $(AM_MAKEFLAGS) check-recursive
Rebased the diff to new port version (2.37 -> 2.40)
firk_cantconnect.ru retitled D37012: math/mpfr: Add INFO option from Add INFO option to math/gmp and math/mpfr to get rid of unconditional texinfo dependency to Add INFO option to math/mpfr to get rid of unconditional texinfo dependency.
Because of math/gmp already patched by PR 259573, removing it from my diff.
Also rebased math/mpfr patch to the new version (but it remains nearly the same).
Jan 16 2023
Jan 16 2023
firk_cantconnect.ru added a comment to D34557: UNIX-socket bind(): distinguish between alive listening socket and random garbage.
@glebius ?
Oct 16 2022
Oct 16 2022
added math/mpfr too
Oct 13 2022
Oct 13 2022
Please note such things:
Sep 21 2022
Sep 21 2022
firk_cantconnect.ru updated the diff for D34557: UNIX-socket bind(): distinguish between alive listening socket and random garbage.
Document the change in man pages.
firk_cantconnect.ru added a comment to D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
In D34579#828698, @glebius wrote:I can't see how this can be used maliciously, e.g. forcing some application outside of jail to send its SCM_RIGHTS to a jail.
Sep 2 2022
Sep 2 2022
with the assumption that client-allocated struct usem is 64-bit aligned
Aug 26 2022
Aug 26 2022
In D36272#825614, @kib wrote:Could you please mail me git format-patch with the change, proper commit log, and author?
removed extra { }
avoid possible race when clearing _has_waiters
Aug 20 2022
Aug 20 2022
related: https://reviews.freebsd.org/D20772
Jul 27 2022
Jul 27 2022
fixed file path in diff
Jun 3 2022
Jun 3 2022
May 28 2022
May 28 2022
firk_cantconnect.ru added a comment to D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
@trasz could you please say something about this?
Mar 30 2022
Mar 30 2022
firk_cantconnect.ru updated the diff for D34637: Allow realtime and precise accounting of cpu utilization for threads and racct-objects..
Found a race between sys_exit() -> exit1() -> thread_exit() and sys_wait() -> proc_reap().
Slightly moving down PROC_SUNLOCK() in thread_exit() to protect RACCT_RT calculations from proc_reap() destroying p->p_racct.
Mar 29 2022
Mar 29 2022
firk_cantconnect.ru added a comment to D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
For example it is possible to share file descriptor tables, and one of the processes may not be encumbered by the jail.
Mar 28 2022
Mar 28 2022
Mar 25 2022
Mar 25 2022
Mar 23 2022
Mar 23 2022
Mar 22 2022
Mar 22 2022
Mar 19 2022
Mar 19 2022
Found same function in lib/libkvm/kvm_proc.c, patch it too.
Mar 17 2022
Mar 17 2022
firk_cantconnect.ru updated the test plan for D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
As for 64/64 divides on 32bit platform: in fact, (nearly) all 32-bit CPUs have a 32-bit tickrate (<4.2GHz), and modern compilers/libraries seems to use 64/32 math in runtime for such a case in 32-bit mode (__udivdi3 function).
Mar 16 2022
Mar 16 2022
I didn't done the test by myself, but this is trivial integer arithmetic.
Is it possible to find out how this was tested?
firk_cantconnect.ru updated the test plan for D34558: Fix imprecisions and timestep in cputime counters.
firk_cantconnect.ru updated the test plan for D34579: Verify directory fds against chroot when receiving them through SCM_RIGHTS.
firk_cantconnect.ru added a comment to D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
Is "firk <firk@cantconnect.ru>" the desired author for the git commit?
Mar 15 2022
Mar 15 2022
firk_cantconnect.ru updated the diff for D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
simplify things according to replies
firk_cantconnect.ru added inline comments to D34559: clock_gettime(CLOCK_THREAD_CPUTIME_ID) was not monotonic due to race.
firk_cantconnect.ru retitled D34560: Add mount option to disallow creating sockets on filesystem from Add mount option to disallow creating socketson filesystem to Add mount option to disallow creating sockets on filesystem.
Mar 14 2022
Mar 14 2022
firk_cantconnect.ru requested review of D34560: Add mount option to disallow creating sockets on filesystem.