I'll commit the change.

LGTM

I'll go ahead and commit.

• Fix typo

• Shorten comment

Looks good; just a few style nits.

Looks pretty good. I would agree that it should be tested on a LEGACY (non-UEFI) BIOS.

LGTM

LGTM

Seems reasonable, although I think the explanation from your description of this change should really go in the code comment rather than the rather terse and enigmatic "Prevent pollution from bogus symbols".

Allocate the buffer based on max_xfer_size as suggested by a review comment.

Combine statements that calculate the transfer size as suggested by review comments.

In D25363#559516, @cem wrote:

Do delete events actually notify on the deleted file? I would expect to receive a notification on the pid's parent directory, but am not sure about the pid file itself.

In D25312#558449, @jhb wrote:

BTW, one thing this leaves ambiguous is [whether] you can declare variables in the middle of blocks vs at the beginning. That is:

Switch from a (uint64_t) cast to specifying ULL on a numeric constant
to widen the data type of an expression (suggested by imp@).

Changes based on some review comments.

Changes based on some review comments.

Let's try uploading that diff again...

Modify the test to handle the nvme drives not starting at 0. I don't
think that is likely, but it is easy enough to handle.

Fix a problem in the devlist test when /dev/nvme0 does _not_ exist.

Remove the shared library unloading code at imp@'s suggestion.

Address comment about check on fd > -1 not being needed in passthru.c.

Correct diff; the previous one had some unintended files included.

Fix a couple issues pointed out in review comments.