I recently made some bug fixes in nvmecontrol. It occurred to
me that since nvmecontrol lacks any kyua tests, I should convert the
informal testing I did into a more formal automated test. The test in
this change should be considered just a starting point; it is neither
complete nor thorough. While converting the test to ATF/kyua, I
discovered a small bug in nvmecontrol; the nvmecontrol devlist
command would always exit with an unsuccessful status. So I included
the fix for that, too, so that the test won't fail.
Details
Details
Run the test.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Modify the test to handle the nvme drives not starting at 0. I don't
think that is likely, but it is easy enough to handle.
Comment Actions
We wire our drives to specific PCI locations, so it can and will happen often. Don't know if we'll be running these tests there, but it's a widely used feature.
Comment Actions
I'm not an expert in atf tests, but this seems reasonable to my eye as a good set of smoke tests.
sbin/nvmecontrol/devlist.c | ||
---|---|---|
130 ↗ | (On Diff #70274) | This change is good, but I'd be tempted to commit it separately. |