Page MenuHomeFreeBSD

zgrep: fix exit status with multiple files

Authored by vangyzen on Sep 30 2020, 9:24 PM.



zgrep should exit with success when given multiple files and the
pattern is found in at least one file. Prior to this change,
it would exit with success only if the pattern was found in _every_ file.

Test Plan

The added test case failed before the fix. All tests pass with the fix.

grep_test:zgrep_multiple_files  ->  passed  [0.022s]

Results file id is usr_tests_usr.bin_grep.20200930-212653-629287
Results saved to /root/.kyua/store/results.usr_tests_usr.bin_grep.20200930-212653-629287.db

52/52 passed (0 failed)

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Oct 1 2020, 1:30 AM

Macro shipit:

898 ↗(On Diff #77704)

"Ensures that zgrep functions properly with multiple files" would be a better comment.

vangyzen added inline comments.
898 ↗(On Diff #77704)

Indeed, it would. (I'm guilty of copy-and-paste.)

This revision was automatically updated to reflect the committed changes.
vangyzen marked an inline comment as done.