Page MenuHomeFreeBSD
Feed Advanced Search

Oct 13 2021

wulf committed rG2c26756366c4: LinuxKPI: implement _IOC_TYPE and _IOC_NR macros in linux/ioctl.h (authored by wulf).
LinuxKPI: implement _IOC_TYPE and _IOC_NR macros in linux/ioctl.h
Oct 13 2021, 9:20 AM
wulf committed rGfd6adf784e86: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers (authored by wulf).
LinuxKPI: Remove FreeBSD struct resource from all LKPI headers
Oct 13 2021, 9:20 AM
wulf committed rGa02996804609: LinuxKPI: Implement get_file_rcu() (authored by wulf).
LinuxKPI: Implement get_file_rcu()
Oct 13 2021, 9:19 AM

Sep 29 2021

wulf committed R11:a15260875683: misc/utouch-kmod: Update to 0.0.3 (authored by wulf).
misc/utouch-kmod: Update to 0.0.3
Sep 29 2021, 10:14 PM
wulf committed R11:315ea99b7ac1: graphics/drm-{current,devel}-kmod: Update after 1400034 (authored by wulf).
graphics/drm-{current,devel}-kmod: Update after 1400034
Sep 29 2021, 9:51 PM
wulf committed rG30acf99a822c: Bump __FreeBSD_version to 1400034 for LinuxKPI changes (authored by wulf).
Bump __FreeBSD_version to 1400034 for LinuxKPI changes
Sep 29 2021, 8:31 PM
wulf committed rG5ca1f3f5e3a3: LinuxKPI: Hide some internal symbols in linux_interrupt.c (authored by wulf).
LinuxKPI: Hide some internal symbols in linux_interrupt.c
Sep 29 2021, 8:31 PM
wulf committed rG062f15004f4e: LinuxKPI: Remove vma argument from fault method of vm_operations_struct (authored by wulf).
LinuxKPI: Remove vma argument from fault method of vm_operations_struct
Sep 29 2021, 8:31 PM
wulf committed rGc072f6e856bc: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod (authored by wulf).
LinuxKPI: Import linux_page.c and some dependent code from drm-kmod
Sep 29 2021, 8:31 PM
wulf committed rG88531adbfbe2: LinuxKPI: Update pte_fn_t definition to match Linux 5.3 (authored by wulf).
LinuxKPI: Update pte_fn_t definition to match Linux 5.3
Sep 29 2021, 8:30 PM
wulf committed rGb52e36384091: LinuxKPI: Implement backlight_enable and backlight_disable functions (authored by wulf).
LinuxKPI: Implement backlight_enable and backlight_disable functions
Sep 29 2021, 8:30 PM
wulf closed D32169: LinuxKPI: Remove vma argument from fault method of vm_operations_struct.
Sep 29 2021, 8:30 PM
wulf closed D32168: LinuxKPI: Hide some symbols in linux_interrupt.c.
Sep 29 2021, 8:30 PM
wulf closed D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.
Sep 29 2021, 8:30 PM
wulf committed rG3d86f8f1d7d1: LinuxKPI: Add dummy pgprot_decrypted() implementation (authored by wulf).
LinuxKPI: Add dummy pgprot_decrypted() implementation
Sep 29 2021, 8:30 PM
wulf closed D32166: LinuxKPI: Update pte_fn_t definition to match Linux 5.3.
Sep 29 2021, 8:30 PM
wulf closed D32165: LinuxKPI: Implement backlight_enable and backlight_disable functions.
Sep 29 2021, 8:30 PM
wulf committed rG37eba5b77a57: LinuxKPI: Cast offset_in_page() parameter to unsigned long (authored by wulf).
LinuxKPI: Cast offset_in_page() parameter to unsigned long
Sep 29 2021, 8:30 PM
wulf closed D32094: LinuxKPI: Add dummy pgprot_decrypted() implementation.
Sep 29 2021, 8:30 PM
wulf closed D32093: LinuxKPI: Cast offset_in_page() parameter to unsigned long.
Sep 29 2021, 8:30 PM
wulf committed rG6efabdeede7f: LinuxKPI: Import linux/poison.h header (authored by wulf).
LinuxKPI: Import linux/poison.h header
Sep 29 2021, 8:30 PM
wulf closed D32092: LinuxKPI: install linux/poison.h header.
Sep 29 2021, 8:30 PM
wulf committed rGb59ffedae8f3: LinuxKPI: Add helper functions to store integers to linux/xarray.h (authored by wulf).
LinuxKPI: Add helper functions to store integers to linux/xarray.h
Sep 29 2021, 8:30 PM
wulf closed D32091: LinuxKPI: Add helper functions to store integers to linux/xarray.h.
Sep 29 2021, 8:29 PM
wulf committed rG62ff0566c930: LinuxKPI: Allow cdev_pager prefault handler to steal pages (authored by wulf).
LinuxKPI: Allow cdev_pager prefault handler to steal pages
Sep 29 2021, 8:29 PM
wulf closed D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 29 2021, 8:29 PM
wulf committed rGbd6d55adb413: LinuxKPI: stub anon_inode_getfile (authored by wulf).
LinuxKPI: stub anon_inode_getfile
Sep 29 2021, 8:29 PM
wulf closed D32069: LinuxKPI: stub anon_inode_getfile.
Sep 29 2021, 8:29 PM
wulf committed rGf6823dac8fa6: LinuxKPI: Factor out vmf_insert_pfn_prot() routine (authored by wulf).
LinuxKPI: Factor out vmf_insert_pfn_prot() routine
Sep 29 2021, 8:29 PM
wulf closed D32068: LinuxKPI: Factor out vmf_insert_pfn_prot() routine.
Sep 29 2021, 8:29 PM
wulf closed D32067: LinuxKPI: Call release handler when file is destroyed with fput().
Sep 29 2021, 8:29 PM
wulf committed rG7d92d4835850: LinuxKPI: Invoke release handler when file is destroyed by fput() (authored by wulf).
LinuxKPI: Invoke release handler when file is destroyed by fput()
Sep 29 2021, 8:29 PM
wulf closed D32066: LinuxKPI: allocate current before taking shrinkers lock.
Sep 29 2021, 8:28 PM
wulf closed D31674: LinuxKPI: implement _IOC_TYPE and _IOC_NR macros in linux/ioctl.h.
Sep 29 2021, 8:28 PM
wulf committed rG2fe9ea5d3ad6: LinuxKPI: allocate current before taking shrinkers lock (authored by wulf).
LinuxKPI: allocate current before taking shrinkers lock
Sep 29 2021, 8:28 PM
wulf committed rGb58c916f115d: LinuxKPI: implement _IOC_TYPE and _IOC_NR macros in linux/ioctl.h (authored by wulf).
LinuxKPI: implement _IOC_TYPE and _IOC_NR macros in linux/ioctl.h
Sep 29 2021, 8:28 PM
wulf closed D31672: LinuxKPI: Implement get_file_rcu().
Sep 29 2021, 8:28 PM
wulf closed D31673: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers.
Sep 29 2021, 8:28 PM
wulf committed rG66ea390652d2: LinuxKPI: Remove FreeBSD struct resource from all LKPI headers (authored by wulf).
LinuxKPI: Remove FreeBSD struct resource from all LKPI headers
Sep 29 2021, 8:28 PM
wulf committed rGa81b36c6d35d: LinuxKPI: Implement get_file_rcu() (authored by wulf).
LinuxKPI: Implement get_file_rcu()
Sep 29 2021, 8:28 PM

Sep 28 2021

wulf updated the diff for D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.
  • Add short comment about unmap_mapping_range() parameters
  • min -> ulmin
Sep 28 2021, 7:40 PM
wulf added inline comments to D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.
Sep 28 2021, 6:29 PM
wulf added a comment to D32168: LinuxKPI: Hide some symbols in linux_interrupt.c.

These symbols are required to load on 13-STABLE kernel module built on 13.0-RELEASE. 13-STABLE alone does not require them exposed

Sep 28 2021, 8:58 AM
wulf added a comment to D32169: LinuxKPI: Remove vma argument from fault method of vm_operations_struct.

Does "buildkernel WITH_OFED=YES" still build?

Sep 28 2021, 8:54 AM
wulf added inline comments to D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.
Sep 28 2021, 8:53 AM
wulf updated the diff for D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.

Use PMAP_HAS_DMAP instead of LP64
Optimize sg_pcopy_to_buffer() for !PMAP_HAS_DMAP case
Move kmap/kunmap implementation in to header file
Drop debugging printf

Sep 28 2021, 8:49 AM
wulf added inline comments to D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.
Sep 28 2021, 12:56 AM

Sep 27 2021

wulf retitled D32168: LinuxKPI: Hide some symbols in linux_interrupt.c from LinuxKPI: Hide some symbols in linux_interrupt.c This is nonMFC-able follow-up to https://reviews.freebsd.org/D31673 to LinuxKPI: Hide some symbols in linux_interrupt.c.
Sep 27 2021, 11:51 PM
wulf requested review of D32169: LinuxKPI: Remove vma argument from fault method of vm_operations_struct.
Sep 27 2021, 11:31 PM
wulf requested review of D32168: LinuxKPI: Hide some symbols in linux_interrupt.c.
Sep 27 2021, 11:31 PM
wulf requested review of D32167: LinuxKPI: Import linux_page.c and some dependent code from drm-kmod.
Sep 27 2021, 11:26 PM
wulf requested review of D32166: LinuxKPI: Update pte_fn_t definition to match Linux 5.3.
Sep 27 2021, 11:16 PM
wulf requested review of D32165: LinuxKPI: Implement backlight_enable and backlight_disable functions.
Sep 27 2021, 11:15 PM

Sep 25 2021

wulf added a comment to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Thank you for the time spent on it

Sep 25 2021, 6:17 PM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Replace KASSERT with printf.

Sep 25 2021, 2:43 PM
wulf added a comment to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Or you are talking to be more error-prone to bugs in userspace drivers?

Sep 25 2021, 2:03 PM
wulf added a comment to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

IMO, Although printf is better in general case, KASSERT is still good choice for i915kms.
It has some cleanup code which removes old mappings[1] and it works
So when i915kms mmaps same pages again (it happens sometimes), nothing bad happens.
I think we should not try to hide problem if the cleanup stopped to work as it happened e.g. on 5.5->5.6 update

Sep 25 2021, 1:47 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 25 2021, 12:09 PM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Revision updated according to last @kib comment

Sep 25 2021, 12:07 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 25 2021, 4:15 AM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 25 2021, 3:26 AM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Add check for owning of the lock for page->object

Sep 25 2021, 3:25 AM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 25 2021, 2:39 AM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Do full cycle retry if vm_page_busy_acquire() has failed

Sep 25 2021, 2:38 AM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 25 2021, 2:09 AM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Pass VM_ALLOC_WAITFAIL flag to vm_page_busy_acquire()

Sep 25 2021, 2:07 AM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 25 2021, 1:29 AM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Allow to steal pages grom any object

Sep 25 2021, 1:23 AM

Sep 24 2021

wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 11:59 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 10:16 PM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Move "page still belongs to shm_obj" check to right place

Sep 24 2021, 10:12 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 9:10 PM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Add unconditional execution of vm_pager_page_unswapped()

Sep 24 2021, 9:08 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 7:59 PM
wulf updated the diff for D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.

Eliminate lock ordering through use of vm_page_remove()

Sep 24 2021, 6:45 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 5:52 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 5:05 PM
wulf added inline comments to D32068: LinuxKPI: Factor out vmf_insert_pfn_prot() routine.
Sep 24 2021, 3:52 PM
wulf added inline comments to D32068: LinuxKPI: Factor out vmf_insert_pfn_prot() routine.
Sep 24 2021, 3:49 PM
wulf updated the diff for D32068: LinuxKPI: Factor out vmf_insert_pfn_prot() routine.

Clarify _Static_assert reason

Sep 24 2021, 3:48 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 3:40 PM
wulf added inline comments to D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 3:24 PM
wulf added a comment to D32092: LinuxKPI: install linux/poison.h header.

It is unmodified file from OpenBSD: https://github.com/openbsd/src/blob/master/sys/dev/pci/drm/include/linux/poison.h

Sep 24 2021, 8:35 AM
wulf added inline comments to D32094: LinuxKPI: Add dummy pgprot_decrypted() implementation.
Sep 24 2021, 8:31 AM
wulf requested review of D32094: LinuxKPI: Add dummy pgprot_decrypted() implementation.
Sep 24 2021, 1:13 AM
wulf requested review of D32093: LinuxKPI: Cast offset_in_page() parameter to unsigned long.
Sep 24 2021, 1:12 AM
wulf requested review of D32092: LinuxKPI: install linux/poison.h header.
Sep 24 2021, 1:11 AM
wulf requested review of D32091: LinuxKPI: Add helper functions to store integers to linux/xarray.h.
Sep 24 2021, 1:11 AM
wulf requested review of D32090: LinuxKPI: Allow cdev_pager prefault handler to steal pages from other vm_objects.
Sep 24 2021, 1:09 AM

Sep 23 2021

wulf added a comment to D31672: LinuxKPI: Implement get_file_rcu().

Yes, it is partial. kfree_rcu in linux_file_free() is new as compared with old version.

Sep 23 2021, 1:49 PM
wulf added a comment to D31672: LinuxKPI: Implement get_file_rcu().

The problem is that the refcount mechanism access f->_file->f_count . You need to free both "f" and "_file" using kfree_rcu() for this to work.
"f" is the Linux file structure and "_file" is the FreeBSD kernel's file structure.

Sep 23 2021, 1:46 PM
wulf updated the diff for D31672: LinuxKPI: Implement get_file_rcu().

Revert close() handler to previous state

Sep 23 2021, 1:42 PM
wulf added a comment to D32068: LinuxKPI: Factor out vmf_insert_pfn_prot() routine.

Looks good. Was this code tested?

Sep 23 2021, 9:17 AM
wulf added a comment to D31672: LinuxKPI: Implement get_file_rcu().

Are you sure this works, that other structure pointers inside the Linux file structure won't be accessed and will also need to be freed by RCU?

Sep 23 2021, 9:00 AM
wulf committed rG9faebc1e664d: hkbd(4): Fix build on 32bit platforms (authored by wulf).
hkbd(4): Fix build on 32bit platforms
Sep 23 2021, 1:06 AM
wulf committed rG510b003ff412: hkbd(4): Fix key repeats on multireport keyboards (authored by wulf).
hkbd(4): Fix key repeats on multireport keyboards
Sep 23 2021, 1:06 AM
wulf committed rG1dec30a65a31: hkbd(4): Use bitstring(3) KPI for key bitmaps processing. (authored by wulf).
hkbd(4): Use bitstring(3) KPI for key bitmaps processing.
Sep 23 2021, 1:06 AM
wulf committed rG7683f19cbf40: hkbd(4): Reduce diff with ukbd(4) (authored by wulf).
hkbd(4): Reduce diff with ukbd(4)
Sep 23 2021, 1:05 AM
wulf committed rG89edde19d3fe: psm(4): Disable KVM switch "jitter" clamping for absolute touchpads. (authored by wulf).
psm(4): Disable KVM switch "jitter" clamping for absolute touchpads.
Sep 23 2021, 1:05 AM
wulf updated the diff for D31672: LinuxKPI: Implement get_file_rcu().

Wait for a grace period when anonymous file is closed with fput().

Sep 23 2021, 12:52 AM