• tidy headers

• tidy headers

• drop error variable

• Remove error variable
• On error, fall back to PAGE_SIZE

After far too many years 😢, I've kicked off a fresh effort to integrate this change. I've got a WIP pull request at https://github.com/freebsd/freebsd-src/pull/908 that isn't complete, but basically works and some prodding with gdb suggests it's doing the right thing in terms of which implementations are being called in simple programs.

In this stack of changed I've verified that the __FBSID entries were added locally and not part of the initial import. Where they were added in a single commit (e.g., moving $FreeBSD$ from a comment to an __FBSID) I've indicated the commit, but many were added adhoc along with other changes (which I vaguely remember being the policy in the CVS days).

In D42688#973984, @imp wrote:

There's many more of these in the tree... these somehow escaped $FreeBSD$ expansion...

I've updated this locally to make the _DIAGASSERT change first as a separate commit.

FWIW, I hit this because I'm looking at generating parts of lib/libc/sys/Symbol.map on the way to a long overdue reimplementation of D14609. Fortunately it's quite a minor change that just touches all the places sysmk support does (unless I decide to generate more of the file which would require annotations).

• Update sort order comment in the correct commit

• Update sort order comment in the correct commit

• clarify sort order