Page MenuHomeFreeBSD

libc: centralize a few numeric symbols
ClosedPublic

Authored by brooks on Nov 15 2023, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 7:09 AM
Unknown Object (File)
Fri, Nov 15, 4:13 AM
Unknown Object (File)
Sep 16 2024, 10:19 PM
Unknown Object (File)
Sep 7 2024, 12:15 PM
Unknown Object (File)
Aug 14 2024, 4:49 AM
Unknown Object (File)
Aug 6 2024, 1:20 AM
Unknown Object (File)
Jul 30 2024, 2:36 PM
Unknown Object (File)
Jul 27 2024, 7:01 PM
Subscribers
None

Details

Summary

fabs, infinity, and nan are universally implemented so declare them
in gen/Symbol.map.

We would also include __flt_rounds for some reason it's under FBSD_1.3
on arm so until that's gone we're stuck with it. Likewise, everyone but
i386 implements g[gs]etmask.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 15 2023, 4:18 PM

We would also include __flt_rounds for some reason it's under FBSD_1.3 on arm so until that's gone we're stuck with it.

I think that's the result of the OABI -> EABI migration... But it may just be random "didn't do it quite right at the time and we're just now noticing" too. arm binaries from that era were super fragile because we played the tier 2/3 card way too often.

In D42618#972475, @imp wrote:

We would also include __flt_rounds for some reason it's under FBSD_1.3 on arm so until that's gone we're stuck with it.

I think that's the result of the OABI -> EABI migration... But it may just be random "didn't do it quite right at the time and we're just now noticing" too. arm binaries from that era were super fragile because we played the tier 2/3 card way too often.

It's from rG061103347c34bf6e495abadc864ad48bcbf85fe6

In D42618#972475, @imp wrote:

We would also include __flt_rounds for some reason it's under FBSD_1.3 on arm so until that's gone we're stuck with it.

I think that's the result of the OABI -> EABI migration... But it may just be random "didn't do it quite right at the time and we're just now noticing" too. arm binaries from that era were super fragile because we played the tier 2/3 card way too often.

It's from rG061103347c34bf6e495abadc864ad48bcbf85fe6

ah, that's too late to be the EABI thing then.

This revision was automatically updated to reflect the committed changes.