In D16719#355614, @johalun0_gmail.com wrote:

In D16719#355599, @imp wrote:

This strikes me as two different changes. One for the phys_avail_reserve() and another to use it for the pci early stuff. I'm a little uneasy with the pci early name, but the code is clearly PCI specific.
Would there ever be a need to do things like this when running the 32-bit kernel? I know we don't support graphics cards there, but when we're bringing in new interfaces, it's a question that suggests itself.
RPi has this sort of thing too, but it's dealt with in the bowels of the FDT code...

Yes, they are two separate things and once we agree on the best solution I can split them up in two reviews. I thought it was easier to get the whole picture if it's all in one place to start with. As for graphics, I'm uncertain about Intel stolen for i386 support. Time will tell. Maybe other devs have ideas?

I couldn't find any port pci read functions to reuse. If there really aren't any, maybe these pci_early_read_* should be made public (with a nicer name)?

Minor fixes and tested now.

Hmmm, I was more wondering if acpi_print_gas() simply needed updating in general for newer GAS parsing in newer ACPI revisions. If instead this is a specific hack just for this table then I don't think acpi_print_gas() needs adjusting. It might be nice to recognize the special case and print it as "MSR=" or some such if that isn't a pain to do. However, if that involves a lot of mess and manual GAS parsing code then the current approach is probably fine.

In D15931#337134, @jhb wrote:

In general this looks fine. I would probably do the NFIT fixup as a separate commit first. Also, changes to manpages generally require updating Dd to the commit date, though it's ok to leave it out of the review and just change that prior to committing.

In D15931#337133, @jhb wrote:

I am far from an expert on ACPI...

• acpidump(8): Add NFIT to manpage missed in r321298
• acpidump(8): Add ACPI LPIT (Low Power Idle Table)

I probably should alphabetize the man page entries...