Forgot to note the review in the commit message, so manually closing the review.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Oct 4 2016
Oct 4 2016
• lidl added inline comments to D8082: Make 502.pfdenied find blacklistd/* filter names
dynamically.
Sep 30 2016
Sep 30 2016
Fix blacklistd's state restoral at startup
Update blacklistd.8 with changes from NetBSD
Sep 29 2016
Sep 29 2016
• lidl added a reviewer for D8081: Make blacklist-helper commands emit a message when
successful: kp.
• lidl added a reviewer for D8082: Make 502.pfdenied find blacklistd/* filter names
dynamically: kp.
This review can be abandoned. The ipfilter support was added several months ago. Any problems with the code would need a new review.
• lidl retitled D8082: Make 502.pfdenied find blacklistd/* filter names
dynamically from to Make 502.pfdenied find blacklistd/* filter names
dynamically.
• lidl added a reviewer for D8081: Make blacklist-helper commands emit a message when
successful: emaste.
• lidl retitled D8081: Make blacklist-helper commands emit a message when
successful from to Make blacklist-helper commands emit a message when
successful.
• lidl retitled D8080: Fix blacklistd's state restoral at startup from to Fix blacklistd's state restoral at startup.
• lidl retitled D8079: Update blacklistd.8 with changes from NetBSD from to Update blacklistd.8 with changes from NetBSD.
Properly preserve ip_tos bits for IPv4 packets
Sep 28 2016
Sep 28 2016
• lidl retitled D8053: Properly preserve ip_tos bits for IPv4 packets from to Properly preserve ip_tos bits for IPv4 packets.
Sep 16 2016
Sep 16 2016
With or without the comment change, the code change looks OK to me.
Sep 6 2016
Sep 6 2016
MFC r305065: Add refactored blacklist support to sshd
Aug 30 2016
Aug 30 2016
Add refactored blacklist support to sshd
Aug 23 2016
Aug 23 2016
This is the same as the last uploaded diff, only generated with -U99999 so the entire content of any affected files can be viewed through Phabricator.
Latest version of the diff, updated based on des' comments.
Aug 12 2016
Aug 12 2016
Aug 5 2016
Aug 5 2016
Jul 29 2016
Jul 29 2016
libblacklist: Do not use %m for logging, use strerror(errno)
Make resizewin.1 manpage use .Fx macro
Jul 15 2016
Jul 15 2016
Refresh diff with latest code.
Updates based on comments received from des@ in email.
Jul 5 2016
Jul 5 2016
Full diff uploaded, as requested by Ed Maste. Should otherwise be the same as the prior diff.
Jul 2 2016
Jul 2 2016
• lidl retitled D7051: Add refactored blacklist support to sshd from to Add refactored blacklist support to sshd.
I placed the option where you suggested in the Makefile, and
adjusted the order of the other parts of the Makefile to match.
Jun 23 2016
Jun 23 2016
Add support for a /etc/defaults/vendor.conf override file
Jun 21 2016
Jun 21 2016
• lidl added a comment to D6900: Allow geom_part schemes to have a different default # entries than minimum..
I'm not opposed to this change. As I read the change, the default action is to still create EFI compliant GPT tables, with the minimum 128 partitions. I'm OK with the system growing the capability to create non-standards-conforming GPT tables, as long as the default is create conforming tables.
Jun 20 2016
Jun 20 2016
I found my email exchange with Devin from earlier this year, and reworked the patch to follow his suggestions. The net effect is the same, a vendor supplied defaults files is sourced at the same point in the execution, just now named "/etc/defaults/vendor.conf" to match the other files named /etc/defaults/*.conf
• lidl added inline comments to D6900: Allow geom_part schemes to have a different default # entries than minimum..
The rc.local execution happens much later in the startup process, after daemons, etc have already started being executed.
Jun 19 2016
Jun 19 2016
• lidl retitled D6895: Add support for a /etc/defaults/vendor.conf override file from to Add support for a /etc/rc.vendor override file.
Jun 17 2016
Jun 17 2016
Note ipfilter support in blacklist-helper script in relnotes
Jun 12 2016
Jun 12 2016
Add ipfilter support to blacklistd-helper
This review has been moved to be relative to the ports/sendmail infrastructure.
• lidl retitled D6823: Add ipfilter support to blacklistd-helper from to Add ipfilter support to blacklistd-helper.
Jun 10 2016
Jun 10 2016
Relnotes entries for blacklist project
Jun 9 2016
Jun 9 2016
When you test this, make sure you test it with IPv6 traffic too.
Add IPFW support to blacklistd-helper
Jun 8 2016
Jun 8 2016
• lidl set the repository for D6753: Add experimental support for IPFW to blacklistd-helper to rS FreeBSD src repository - subversion.
Updated to reflect first pass of review comments. Note - this round of changes hasn't been tested on my virtual machine (yet).
• lidl retitled D6753: Add experimental support for IPFW to blacklistd-helper from to Add experimental support for IPFW to blacklistd-helper.
Jun 7 2016
Jun 7 2016
Bump dates in blacklist related manpages
Document BLACKLIST related build options
Separate BLACKLIST vs BLACKLIST_SUPPORT properly
Note blacklist support first appeared in FreeBSD 11
Add blacklist support to sshd
• lidl closed D5915: Add blacklist support to sshd by committing rS301551: Add blacklist support to sshd.
Jun 6 2016
Jun 6 2016
Update blacklist support in ftpd to clarify fd usage
Turn off blacklistd daemon in defaults
Jun 5 2016
Jun 5 2016
Add blacklist support to rlogind
• lidl closed D6593: Add blacklist support to rlogind by committing rS301417: Add blacklist support to rlogind.
Correct path for blacklistd.conf in OptionalObsoleteFiles.inc
Jun 4 2016
Jun 4 2016
• lidl retitled D6716: Update blacklist support in ftpd to clarify fd usage from to Update blacklist support in ftpd to clarify fd usage.
• lidl retitled D6715: Correct path for blacklistd.conf in OptionalObsoleteFiles.inc from to Correct path for blacklistd.conf in OptionalObsoleteFiles.inc.
Jun 3 2016
Jun 3 2016
• lidl closed D5916: Add blacklist support to fingerd by committing rS301243: Add blacklist support to fingerd.
Add blacklist support to fingerd
Add blacklist support to rshd
• lidl closed D6594: Add blacklist support to rshd by committing rS301242: Add blacklist support to rshd.
Add blacklist support to ftpd
• lidl closed D6703: Add blacklist support to ftpd by committing rS301241: Add blacklist support to ftpd.
Add blacklistd.conf manpage
• lidl closed D6702: Add blacklistd.conf manpage by committing rS301240: Add blacklistd.conf manpage.
Added NetBSD copyrights to appropriate files.
Rename 'a' variable to 'action' to better reflect its usage.
Jun 2 2016
Jun 2 2016
Add basic blacklist build support
• lidl closed D5913: Add basic blacklist build support by committing rS301226: Add basic blacklist build support.
Fixup path in NetBSD supplied documentation for FreeBSD
Jun 1 2016
Jun 1 2016
Import NetBSD's blacklist source from vendor tree
Tag import of NetBSD's external/bsd/blacklist
• lidl closed D5912: Import NetBSD external/bsd/blacklist @ 20160409 by committing rS301169: Reviewed by: rpaulo.
May 30 2016
May 30 2016
Oops. This is incomplete. Doesn't handle the chroot() done for anonymous ftp properly. I will update with a more complete version soon.
Remove extraneous altq header files
• lidl closed D6596: Remove extraneous altq files by committing rS300980: Remove extraneous altq header files.
May 28 2016
May 28 2016