Page MenuHomeFreeBSD

Update blacklist support in ftpd to clarify fd usage
ClosedPublic

Authored by • lidl on Jun 4 2016, 3:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 10:44 PM
Unknown Object (File)
Sun, Sep 13, 1:42 PM
Unknown Object (File)
Fri, Sep 11, 11:15 PM
Unknown Object (File)
Aug 26 2026, 6:01 PM
Unknown Object (File)
Aug 21 2026, 9:55 AM
Unknown Object (File)
Aug 11 2026, 5:37 AM
Unknown Object (File)
Aug 5 2026, 1:43 PM
Unknown Object (File)
Jul 27 2026, 2:13 PM
Subscribers

Details

Summary

The code in ftpd dups the socket to stdin, and then uses fd 0
explicitly throughout the code. Clarify this slightly in
the non-blacklist code. Make the blacklist_notify routine
use STDIN_FILENO so as to have less of a "magic number" feel
to the code.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• lidl retitled this revision from to Update blacklist support in ftpd to clarify fd usage.
• lidl updated this object.
• lidl edited the test plan for this revision. (Show Details)
• lidl added reviewers: rpaulo, emaste, cem.
• lidl set the repository for this revision to rS FreeBSD src repository - subversion.
cem edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2016, 3:34 AM
This revision was automatically updated to reflect the committed changes.