Page MenuHomeFreeBSD

Update blacklist support in ftpd to clarify fd usage
ClosedPublic

Authored by lidl on Jun 4 2016, 3:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2024, 12:03 PM
Unknown Object (File)
Sep 29 2024, 11:24 PM
Unknown Object (File)
Sep 23 2024, 8:31 PM
Unknown Object (File)
Sep 17 2024, 11:01 AM
Unknown Object (File)
Sep 13 2024, 8:39 PM
Unknown Object (File)
Sep 8 2024, 4:46 PM
Unknown Object (File)
Sep 8 2024, 4:50 AM
Unknown Object (File)
Sep 7 2024, 11:28 PM
Subscribers

Details

Summary

The code in ftpd dups the socket to stdin, and then uses fd 0
explicitly throughout the code. Clarify this slightly in
the non-blacklist code. Make the blacklist_notify routine
use STDIN_FILENO so as to have less of a "magic number" feel
to the code.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lidl retitled this revision from to Update blacklist support in ftpd to clarify fd usage.
lidl updated this object.
lidl edited the test plan for this revision. (Show Details)
lidl added reviewers: rpaulo, emaste, cem.
lidl set the repository for this revision to rS FreeBSD src repository - subversion.
cem edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2016, 3:34 AM
This revision was automatically updated to reflect the committed changes.