Page MenuHomeFreeBSD

Make blacklist-helper commands emit a message when successful
ClosedPublic

Authored by lidl on Sep 29 2016, 8:49 PM.

Details

Summary

The blacklistd daemon expects to see a message on stdout, instead
of just relying on the exit value from any invoked programs.

Change the pf filtering to create multiple filters, attached under
a the "blacklist/*" anchor point. This prevents the filtering for
each port's filtering rule from overwriting the previously installed
filtering rule. Check for an existing filtering rule for each port,
so the installation of a given filtering rule only happens once.
Reinstalling the same rule resets the counters for the pf rule, and
we don't want that.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lidl updated this revision to Diff 20827.Sep 29 2016, 8:49 PM
lidl retitled this revision from to Make blacklist-helper commands emit a message when successful.
lidl updated this object.
lidl edited the test plan for this revision. (Show Details)
lidl set the repository for this revision to rS FreeBSD src repository.
lidl added a reviewer: emaste.Sep 29 2016, 8:49 PM
emaste accepted this revision.Sep 29 2016, 9:12 PM
emaste edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 9:12 PM
emaste added inline comments.Sep 29 2016, 9:13 PM
contrib/blacklist/libexec/blacklistd-helper
93–94 ↗(On Diff #20827)

I think these should be <tabs...><4 spaces>echo OK for the 2nd-level indent

lidl added a reviewer: kp.Sep 29 2016, 9:31 PM
lidl marked an inline comment as done.Oct 4 2016, 11:05 PM

I have taken all the third-level indents and turned them into 4 spaces, as per emaste's request. There was also one line longer than 80 characters that I manually wrapped.

This revision was automatically updated to reflect the committed changes.