Paths

Table of Contentst

Differential D33270

tcp: virtualise net.inet.tcp.msl sysctl.
ClosedPublic
Actions

Authored by melifaro on Dec 4 2021, 10:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 1, 12:15 PM

	Unknown Object (File)
	Thu, Apr 30, 2:53 AM

	Unknown Object (File)
	Tue, Apr 28, 4:29 PM

	Unknown Object (File)
	Tue, Apr 28, 3:10 PM

	Unknown Object (File)
	Tue, Apr 28, 11:45 AM

	Unknown Object (File)
	Mon, Apr 27, 5:19 PM

	Unknown Object (File)
	Sat, Apr 25, 5:10 PM

	Unknown Object (File)
	Fri, Apr 24, 2:16 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG81a72d997e22: tcp: virtualise net.inet.tcp.msl sysctl.
rGd64a952f8d8a: tcp: virtualise net.inet.tcp.msl sysctl.
rG057793e63771: tcp: virtualise net.inet.tcp.msl sysctl.
rGc2c8e360d8c0: tcp: virtualise net.inet.tcp.msl sysctl.

Summary

VNET teardown waits 2*MSL (60 seconds by default) before expiring
tcp PCBs. These PCBs holds references to nexthops, which, in turn,
reference ifnets. This chain results in VNET interfaces being destroyed
and moved to default VNET only after 60 seconds.
Allow tcp_msl to be set in jail by virtualising net.inet.tcp.msl sysctl,
permitting more predictable VNET tests outcomes.

MFC after: 1 week

Test Plan

# s ifconfig lo create
lo3
# s jail -c name=test persist vnet vnet.interface="lo3"
# s jexec test sysctl net.inet.tcp.msl=100
net.inet.tcp.msl: 30000 -> 100
# s jexec test sysctl net.inet.tcp.msl
net.inet.tcp.msl: 100
# sysctl net.inet.tcp.msl
net.inet.tcp.msl: 30000

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43149
Build 40037: arc lint + arc unit

Event Timeline

melifaro created this revision.Dec 4 2021, 10:09 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 4 2021, 10:09 PM

Herald added subscribers: glebius, imp. · View Herald Transcript

melifaro requested review of this revision.Dec 4 2021, 10:09 PM

Harbormaster completed remote builds in B43149: Diff 99458.Dec 4 2021, 10:09 PM

.

Harbormaster completed remote builds in B43150: Diff 99459.Dec 4 2021, 10:14 PM

glebius added inline comments.Dec 4 2021, 10:15 PM

sys/netinet/tcp_timer.c
122–123	While here you can remove CTLFLAG_NEEDGIANT.

melifaro edited the test plan for this revision. (Show Details)Dec 4 2021, 10:26 PM

melifaro edited the test plan for this revision. (Show Details)

Remove NEEDGIANT.

Harbormaster completed remote builds in B43163: Diff 99505.Dec 5 2021, 10:47 PM

glebius accepted this revision.Dec 6 2021, 6:41 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2021, 3:06 PM

Closed by commit rGc2c8e360d8c0: tcp: virtualise net.inet.tcp.msl sysctl. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGc2c8e360d8c0: tcp: virtualise net.inet.tcp.msl sysctl..

Can't you use in the jail tcpdrop -s TIME_WAIT to deterministically terminate all TCP connection in the TIME_WAIT state?

melifaro added a commit: rG057793e63771: tcp: virtualise net.inet.tcp.msl sysctl..Mar 28 2022, 9:16 AM

melifaro added a commit: rGd64a952f8d8a: tcp: virtualise net.inet.tcp.msl sysctl..Mar 28 2022, 3:26 PM

melifaro added a commit: rG81a72d997e22: tcp: virtualise net.inet.tcp.msl sysctl..Jan 13 2023, 9:25 PM

melifaro added a reverting change: rGddd3818317b5: Revert "tcp: virtualise net.inet.tcp.msl sysctl.".Jan 23 2023, 11:38 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

2 lines

3 lines

6 lines

2 lines

Diff 99458

sys/netinet/tcp_subr.c

Loading...

sys/netinet/tcp_timer.h

Loading...

sys/netinet/tcp_timer.c

Loading...

sys/netinet/tcp_timewait.c

Loading...