Page MenuHomeFreeBSD

epair: use serialize/restore m_pkthdr.rcvif when queueing mbufs
AbandonedPublic

Authored by glebius on Dec 4 2021, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 16 2025, 9:32 PM
Unknown Object (File)
Nov 11 2025, 8:27 PM
Unknown Object (File)
Nov 10 2025, 6:40 PM
Unknown Object (File)
Oct 29 2025, 2:39 AM
Unknown Object (File)
Oct 29 2025, 2:35 AM
Unknown Object (File)
Oct 25 2025, 9:00 PM
Unknown Object (File)
Oct 14 2025, 9:18 AM
Unknown Object (File)
Oct 12 2025, 9:16 AM
Subscribers

Details

Reviewers
bz
kp
Group Reviewers
network

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43148
Build 40036: arc lint + arc unit

Event Timeline

Is it worth doing that here? We're storing the mbuf in the context of a struct ifnet anyway. It might make more sense to just clear rcvif when we enqueue it and populate it again in epair_sintr().
That's sort of what we do in "real" network drivers as well. We populate rcvif in the receive path.

In D33269#752504, @kp wrote:

Is it worth doing that here? We're storing the mbuf in the context of a struct ifnet anyway. It might make more sense to just clear rcvif when we enqueue it and populate it again in epair_sintr().
That's sort of what we do in "real" network drivers as well. We populate rcvif in the receive path.

This makes a lot of sense. I will abandon this revision in favor of a different one.