Page MenuHomeFreeBSD

epair: use serialize/restore m_pkthdr.rcvif when queueing mbufs
AbandonedPublic

Authored by glebius on Dec 4 2021, 9:18 PM.
Tags
None
Referenced Files
F156887026: D33269.diff
Sun, May 17, 2:19 AM
Unknown Object (File)
Tue, May 12, 3:33 PM
Unknown Object (File)
Tue, May 12, 3:33 PM
Unknown Object (File)
Mon, May 11, 4:18 AM
Unknown Object (File)
Mon, Apr 27, 5:18 PM
Unknown Object (File)
Mon, Apr 27, 2:36 PM
Unknown Object (File)
Mar 27 2026, 7:06 AM
Unknown Object (File)
Mar 27 2026, 12:04 AM
Subscribers

Details

Reviewers
bz
kp
Group Reviewers
network

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43148
Build 40036: arc lint + arc unit

Event Timeline

Is it worth doing that here? We're storing the mbuf in the context of a struct ifnet anyway. It might make more sense to just clear rcvif when we enqueue it and populate it again in epair_sintr().
That's sort of what we do in "real" network drivers as well. We populate rcvif in the receive path.

In D33269#752504, @kp wrote:

Is it worth doing that here? We're storing the mbuf in the context of a struct ifnet anyway. It might make more sense to just clear rcvif when we enqueue it and populate it again in epair_sintr().
That's sort of what we do in "real" network drivers as well. We populate rcvif in the receive path.

This makes a lot of sense. I will abandon this revision in favor of a different one.