Page MenuHomeFreeBSD

epair: use serialize/restore m_pkthdr.rcvif when queueing mbufs
AbandonedPublic

Authored by glebius on Dec 4 2021, 9:18 PM.
Tags
None
Referenced Files
F82227889: D33269.diff
Fri, Apr 26, 6:13 PM
Unknown Object (File)
Jan 25 2024, 6:35 AM
Unknown Object (File)
Dec 20 2023, 4:29 AM
Unknown Object (File)
Dec 11 2023, 7:04 AM
Unknown Object (File)
Nov 22 2023, 1:41 PM
Unknown Object (File)
Sep 20 2023, 2:40 PM
Unknown Object (File)
Sep 6 2023, 8:18 AM
Unknown Object (File)
Aug 14 2023, 11:15 PM
Subscribers

Details

Reviewers
bz
kp
Group Reviewers
network

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43148
Build 40036: arc lint + arc unit

Event Timeline

Is it worth doing that here? We're storing the mbuf in the context of a struct ifnet anyway. It might make more sense to just clear rcvif when we enqueue it and populate it again in epair_sintr().
That's sort of what we do in "real" network drivers as well. We populate rcvif in the receive path.

In D33269#752504, @kp wrote:

Is it worth doing that here? We're storing the mbuf in the context of a struct ifnet anyway. It might make more sense to just clear rcvif when we enqueue it and populate it again in epair_sintr().
That's sort of what we do in "real" network drivers as well. We populate rcvif in the receive path.

This makes a lot of sense. I will abandon this revision in favor of a different one.